| OLD | NEW |
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| 11 | 11 |
| 12 Still reading? | 12 Still reading? |
| 13 - You can edit this file manually to suppress an issue | 13 - You can edit this file manually to suppress an issue |
| 14 globally if it is not applicable to the project. | 14 globally if it is not applicable to the project. |
| 15 - You can also automatically add issues found so for in the | 15 - You can also automatically add issues found so for in the |
| 16 build process by running: | 16 build process by running: |
| 17 | 17 |
| 18 build/android/lint/suppress.py | 18 build/android/lint/suppress.py |
| 19 | 19 |
| 20 which will generate this file (Comments are not preserved). | 20 which will generate this file (Comments are not preserved). |
| 21 Note: PRODUCT_DIR will be substituted at run-time with actual | 21 Note: PRODUCT_DIR will be substituted at run-time with actual |
| 22 directory path (e.g. out/Debug) | 22 directory path (e.g. out/Debug) |
| 23 --> | 23 --> |
| 24 <!-- AllowBackup defaults to true, and causes a lint warning if not explicitly
set. --> | 24 <!-- AllowBackup defaults to true, and causes a lint warning if not explicitly
set. --> |
| 25 <issue id="AllowBackup"> | 25 <issue id="AllowBackup"> |
| 26 <ignore path="AndroidManifest.xml"/> | 26 <ignore path="AndroidManifest.xml"/> |
| 27 </issue> | 27 </issue> |
| 28 <!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromiu
m/src/+/master/styleguide/java/java.md#Asserts --> | 28 <!-- We use asserts in Chromium. See https://chromium.googlesource.com/chromiu
m/src/+/master/styleguide/java/java.md#Asserts --> |
| 29 <issue id="Assert" severity="ignore"/> | 29 <issue id="Assert" severity="ignore"/> |
| 30 <issue id="AuthLeak" severity="Error"> |
| 31 <ignore regexp="chrome/android/javatests"/> |
| 32 </issue> |
| 30 <issue id="BadHostnameVerifier" severity="Error"> | 33 <issue id="BadHostnameVerifier" severity="Error"> |
| 31 <!-- Safe, used in test only. --> | 34 <!-- Safe, used in test only. --> |
| 32 <ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/Te
stWebServer.java"/> | 35 <ignore regexp="net/test/android/javatests/src/org/chromium/net/test/util/Te
stWebServer.java"/> |
| 33 </issue> | 36 </issue> |
| 34 <issue id="ButtonOrder" severity="Error"> | 37 <issue id="ButtonOrder" severity="Error"> |
| 35 <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/> | 38 <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml"/> |
| 36 </issue> | 39 </issue> |
| 37 <issue id="ButtonStyle" severity="Error"> | 40 <issue id="ButtonStyle" severity="Error"> |
| 38 <ignore regexp="remoting/android/host/res/layout/main.xml"/> | 41 <ignore regexp="remoting/android/host/res/layout/main.xml"/> |
| 39 </issue> | 42 </issue> |
| 43 <!-- Found in generated android_chrome_strings.xml. --> |
| 44 <issue id="ByteOrderMark" severity="Error"> |
| 45 <ignore regexp="values-pt-rBR/android_chrome_strings.xml"/> |
| 46 </issue> |
| 40 <issue id="CommitPrefEdits"> | 47 <issue id="CommitPrefEdits"> |
| 41 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali
dation/ticl/android2/channel/AndroidChannelPreferences.java"/> | 48 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali
dation/ticl/android2/channel/AndroidChannelPreferences.java"/> |
| 42 </issue> | 49 </issue> |
| 43 <issue id="ContentDescription" severity="Error"> | 50 <issue id="ContentDescription" severity="Error"> |
| 44 <ignore regexp="chromecast/internal"/> | 51 <ignore regexp="chromecast/internal"/> |
| 45 </issue> | 52 </issue> |
| 46 <issue id="DefaultLocale"> | 53 <issue id="DefaultLocale"> |
| 47 <ignore regexp="clank"/> | 54 <ignore regexp="clank"/> |
| 48 <ignore regexp="com/android/tv"/> | 55 <ignore regexp="com/android/tv"/> |
| 49 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe
st.class"/> | 56 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe
st.class"/> |
| 50 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr
eferences"/> | 57 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr
eferences"/> |
| 51 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre
ferences"/> | 58 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre
ferences"/> |
| 52 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali
dation/external/client/contrib/AndroidListenerState.java"/> | 59 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali
dation/external/client/contrib/AndroidListenerState.java"/> |
| 53 </issue> | 60 </issue> |
| 54 <!-- TODO(crbug.com/635567): Fix this properly. --> | 61 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 55 <issue id="Deprecated" severity="Error"> | 62 <issue id="Deprecated" severity="Error"> |
| 63 <ignore regexp="android:singleLine"/> |
| 56 <ignore regexp="AndroidManifest.xml"/> | 64 <ignore regexp="AndroidManifest.xml"/> |
| 65 <ignore regexp="/test/"/> |
| 57 </issue> | 66 </issue> |
| 58 <issue id="DrawAllocation"> | 67 <issue id="DrawAllocation"> |
| 59 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/ContentViewRenderView.java"/> | 68 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/ContentViewRenderView.java"/> |
| 60 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/PopupZoomer.java"/> | 69 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/PopupZoomer.java"/> |
| 61 </issue> | 70 </issue> |
| 62 <issue id="ExportedContentProvider"> | 71 <issue id="ExportedContentProvider"> |
| 63 <ignore path="AndroidManifest.xml"/> | 72 <ignore path="AndroidManifest.xml"/> |
| 64 </issue> | 73 </issue> |
| 65 <issue id="ExportedService" severity="Error"> | 74 <issue id="ExportedService" severity="Error"> |
| 66 <ignore regexp="AndroidManifest.xml"/> | 75 <ignore regexp="AndroidManifest.xml"/> |
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 115 <issue id="IconDuplicatesConfig" severity="Error"> | 124 <issue id="IconDuplicatesConfig" severity="Error"> |
| 116 <ignore regexp="chromecast/internal"/> | 125 <ignore regexp="chromecast/internal"/> |
| 117 </issue> | 126 </issue> |
| 118 <issue id="IconLauncherShape" severity="Error"> | 127 <issue id="IconLauncherShape" severity="Error"> |
| 119 <ignore regexp="chromecast/internal"/> | 128 <ignore regexp="chromecast/internal"/> |
| 120 </issue> | 129 </issue> |
| 121 <issue id="IconLocation"> | 130 <issue id="IconLocation"> |
| 122 <ignore regexp="chromecast/internal"/> | 131 <ignore regexp="chromecast/internal"/> |
| 123 <!-- It is OK for content_shell_apk to have missing assets. --> | 132 <!-- It is OK for content_shell_apk to have missing assets. --> |
| 124 <ignore regexp="content/shell/android/java/res/"/> | 133 <ignore regexp="content/shell/android/java/res/"/> |
| 125 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. --> | |
| 126 <ignore regexp="remoting/android/java/res"/> | |
| 127 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr
awable/icon.png --> | 134 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr
awable/icon.png --> |
| 128 <ignore regexp="res/drawable/icon.png"/> | 135 <ignore regexp="res/drawable/icon.png"/> |
| 129 </issue> | 136 </issue> |
| 130 <issue id="IconMissingDensityFolder"> | 137 <issue id="IconMissingDensityFolder"> |
| 131 <!-- see crbug.com/542435 --> | 138 <!-- see crbug.com/542435 --> |
| 132 <ignore regexp="android_webview/apk/java/res"/> | 139 <ignore regexp="android_webview/apk/java/res"/> |
| 133 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/> | 140 <ignore regexp="android_webview/tools/system_webview_shell/apk/res"/> |
| 134 <ignore regexp="chrome/android/webapk/shell_apk/res"/> | 141 <ignore regexp="chrome/android/webapk/shell_apk/res"/> |
| 135 <ignore regexp="chromecast/internal"/> | 142 <ignore regexp="chromecast/internal"/> |
| 136 <ignore regexp="tools/android/push_apps_to_background/res"/> | 143 <ignore regexp="tools/android/push_apps_to_background/res"/> |
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 202 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas
s"/> | 209 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas
s"/> |
| 203 <ignore regexp="org/chromium/base/JavaHandlerThread.class"/> | 210 <ignore regexp="org/chromium/base/JavaHandlerThread.class"/> |
| 204 <ignore regexp="org/chromium/base/SysUtils.class"/> | 211 <ignore regexp="org/chromium/base/SysUtils.class"/> |
| 205 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class"/> | 212 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class"/> |
| 206 <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class"/> | 213 <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class"/> |
| 207 <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class"/> | 214 <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class"/> |
| 208 <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class"/> | 215 <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class"/> |
| 209 <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class"/> | 216 <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class"/> |
| 210 <ignore regexp="org/chromium/memconsumer/ResidentService.class"/> | 217 <ignore regexp="org/chromium/memconsumer/ResidentService.class"/> |
| 211 <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class"/> | 218 <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class"/> |
| 219 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 220 <ignore regexp="third_party/android_tools/sdk/extras/chromium/support/src/or
g/chromium/android/support/PackageManagerWrapper.java"/> |
| 212 </issue> | 221 </issue> |
| 213 <issue id="OldTargetApi"> | 222 <issue id="OldTargetApi"> |
| 214 <ignore path="AndroidManifest.xml"/> | 223 <ignore path="AndroidManifest.xml"/> |
| 215 </issue> | 224 </issue> |
| 216 <issue id="Overdraw" severity="ignore"/> | 225 <issue id="Overdraw" severity="ignore"/> |
| 217 <issue id="Override"> | 226 <issue id="Override"> |
| 218 <!-- TODO(crbug.com/635567): Fix this properly. --> | 227 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 219 <ignore regexp="org/chromium/content/browser/input/ThreadedInputConnection.c
lass"/> | 228 <ignore regexp="org/chromium/content/browser/input/ThreadedInputConnection.c
lass"/> |
| 220 <!-- TODO(crbug.com/635567): Fix this properly. --> | 229 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 221 <ignore regexp="com/android/webview/chromium/ContentSettingsAdapter.class"/> | 230 <ignore regexp="com/android/webview/chromium/ContentSettingsAdapter.class"/> |
| 222 <!-- TODO(crbug.com/635567): Fix this properly. --> | 231 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 223 <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter.
class"/> | 232 <ignore regexp="com/android/webview/chromium/ServiceWorkerControllerAdapter.
class"/> |
| 224 <!-- TODO(crbug.com/635567): Fix this properly. --> | 233 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 225 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl
ass"/> | 234 <ignore regexp="com/android/webview/chromium/ServiceWorkerSettingsAdapter.cl
ass"/> |
| 226 <!-- TODO(crbug.com/635567): Fix this properly. --> | 235 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 227 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/> | 236 <ignore regexp="org/chromium/chrome/browser/ChromeActivity.class"/> |
| 228 <!-- TODO(crbug.com/635567): Fix this properly. --> | 237 <!-- TODO(crbug.com/635567): Fix this properly. --> |
| 229 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/> | 238 <ignore regexp="org/chromium/chrome/browser/ChromeTabbedActivity.class"/> |
| 230 </issue> | 239 </issue> |
| 231 <issue id="PackageManagerGetSignatures"> | 240 <issue id="PackageManagerGetSignatures"> |
| 232 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li
b/client/WebApkValidator.java"/> | 241 <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/li
b/client/WebApkValidator.java"/> |
| 233 </issue> | 242 </issue> |
| 234 <issue id="PluralsCandidate" severity="Error"> | 243 <issue id="PluralsCandidate" severity="Error"> |
| 235 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-e
n-rGB/android_chrome_strings.xml"/> | 244 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-e
n-rGB/android_chrome_strings.xml"/> |
| 236 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a
ndroid_chrome_strings.xml"/> | 245 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a
ndroid_chrome_strings.xml"/> |
| 237 </issue> | 246 </issue> |
| 238 <issue id="Recycle" severity="ignore"/> | 247 <issue id="Recycle" severity="ignore"/> |
| 239 <issue id="Registered" severity="ignore"/> | 248 <issue id="Registered" severity="ignore"/> |
| 249 <issue id="ResourceType" severity="Error"> |
| 250 <ignore regexp="/javatests/"/> |
| 251 </issue> |
| 240 <issue id="RtlCompat" severity="ignore"/> | 252 <issue id="RtlCompat" severity="ignore"/> |
| 241 <issue id="RtlEnabled" severity="ignore"/> | 253 <issue id="RtlEnabled" severity="ignore"/> |
| 242 <issue id="RtlSymmetry" severity="ignore"/> | 254 <issue id="RtlSymmetry" severity="ignore"/> |
| 243 <issue id="SdCardPath"> | 255 <issue id="SdCardPath"> |
| 244 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/MediaResourceGetter.java"/> | 256 <ignore regexp="content/public/android/java/src/org/chromium/content/browser
/MediaResourceGetter.java"/> |
| 245 </issue> | 257 </issue> |
| 246 <issue id="SetJavaScriptEnabled" severity="ignore"/> | 258 <issue id="SetJavaScriptEnabled" severity="ignore"/> |
| 247 <issue id="SignatureOrSystemPermissions" severity="ignore"/> | 259 <issue id="SignatureOrSystemPermissions" severity="ignore"/> |
| 248 <issue id="SpUsage" severity="Error"> | 260 <issue id="SpUsage" severity="Error"> |
| 249 <ignore regexp="chromecast/internal"/> | 261 <ignore regexp="chromecast/internal"/> |
| (...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 439 <ignore regexp="AndroidManifest.xml"/> | 451 <ignore regexp="AndroidManifest.xml"/> |
| 440 </issue> | 452 </issue> |
| 441 <issue id="ValidFragment" severity="Error"> | 453 <issue id="ValidFragment" severity="Error"> |
| 442 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/BaseMediaRouteDialogManager.java"/> | 454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/BaseMediaRouteDialogManager.java"/> |
| 443 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/MediaRouteChooserDialogManager.java"/> | 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/MediaRouteChooserDialogManager.java"/> |
| 444 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/MediaRouteControllerDialogManager.java"/> | 456 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro
uter/MediaRouteControllerDialogManager.java"/> |
| 445 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen
ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> | 457 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen
ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> |
| 446 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc
reenCapture.java"/> | 458 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc
reenCapture.java"/> |
| 447 </issue> | 459 </issue> |
| 448 <issue id="ViewConstructor" severity="ignore"/> | 460 <issue id="ViewConstructor" severity="ignore"/> |
| 461 <issue id="VisibleForTests" severity="Error"> |
| 462 <ignore regexp="chrome/android/javatests"/> |
| 463 <ignore regexp="/test/"/> |
| 464 </issue> |
| 449 <issue id="WrongCall" severity="ignore"/> | 465 <issue id="WrongCall" severity="ignore"/> |
| 450 <issue id="WrongConstant"> | 466 <issue id="WrongConstant"> |
| 451 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien
tCertificateRequest.java"/> | 467 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien
tCertificateRequest.java"/> |
| 452 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments
/ui/EditorView.java"/> | 468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments
/ui/EditorView.java"/> |
| 453 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S
igninAndSyncView.java"/> | 469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S
igninAndSyncView.java"/> |
| 454 </issue> | 470 </issue> |
| 455 </lint> | 471 </lint> |
| OLD | NEW |