Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2828143006: AudioSystemImpl binding cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by o1ka
Modified:
5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, audio-mojo-cl_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioSystemImpl binding cleanup BUG=672468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2828143006 Cr-Commit-Position: refs/heads/master@{#466324} Committed: https://chromium.googlesource.com/chromium/src/+/402945dae4329cd6e3b2cbeaaf8846818ca92ec5

Patch Set 1 #

Messages

Total messages: 21 (12 generated)
o1ka
PTAL
5 months ago (2017-04-21 12:42:14 UTC) #6
Max Morin
Callback types in the public interface should probably also be Once?
5 months ago (2017-04-21 12:44:24 UTC) #7
o1ka
On 2017/04/21 12:44:24, Max Morin wrote: > Callback types in the public interface should probably ...
5 months ago (2017-04-21 12:48:45 UTC) #8
Max Morin
On 2017/04/21 12:48:45, o1ka wrote: > On 2017/04/21 12:44:24, Max Morin wrote: > > Callback ...
5 months ago (2017-04-21 12:55:18 UTC) #9
o1ka
tommi@chromium.org: could you RS?
5 months ago (2017-04-21 12:57:05 UTC) #11
tommi (sloooow) - chröme
lgtm
5 months ago (2017-04-21 12:59:18 UTC) #13
o1ka
thank you both!
5 months ago (2017-04-21 12:59:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828143006/1
5 months ago (2017-04-21 13:57:31 UTC) #18
commit-bot: I haz the power
5 months ago (2017-04-21 14:02:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/402945dae4329cd6e3b2cbeaaf88...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b