AudioSystemImpl binding cleanup

AudioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2828143006
Cr-Commit-Position: refs/heads/master@{#466324}
Committed: https://chromium.googlesource.com/chromium/src/+/402945dae4329cd6e3b2cbeaaf8846818ca92ec5

[o1ka, 2017-04-21 12:03:33]

Description was changed from

==========
udioSystemImpl binding cleanup

BUG=672468
==========

to

==========
udioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[o1ka, 2017-04-21 12:03:47]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 12:03:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2017-04-21 12:06:43]

Description was changed from

==========
udioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
udioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[o1ka, 2017-04-21 12:41:58]

olka@chromium.org changed reviewers:
+ maxmorin@chromium.org

[o1ka, 2017-04-21 12:42:14]

PTAL

[Max Morin, 2017-04-21 12:44:24]

Callback types in the public interface should probably also be Once?

[o1ka, 2017-04-21 12:48:45]

On 2017/04/21 12:44:24, Max Morin wrote:
> Callback types in the public interface should probably also be Once?

PostTaskAndReplyWithResult does not accept Once yet.

[Max Morin, 2017-04-21 12:55:18]

On 2017/04/21 12:48:45, o1ka wrote:
> On 2017/04/21 12:44:24, Max Morin wrote:
> > Callback types in the public interface should probably also be Once?
> 
> PostTaskAndReplyWithResult does not accept Once yet.

lgtm then, and we can fix it some other time.

[o1ka, 2017-04-21 12:57:04]

olka@chromium.org changed reviewers:
+ tommi@chromium.org

[o1ka, 2017-04-21 12:57:05]

tommi@chromium.org: could you RS?

[tommi (sloooow) - chröme, 2017-04-21 12:58:57]

Description was changed from

==========
udioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
AudioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tommi (sloooow) - chröme, 2017-04-21 12:59:18]

lgtm

[o1ka, 2017-04-21 12:59:50]

thank you both!

[commit-bot: I haz the power, 2017-04-21 13:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 13:43:50]

Dry run: This issue passed the CQ dry run.

[o1ka, 2017-04-21 13:57:10]

The CQ bit was checked by olka@chromium.org

[commit-bot: I haz the power, 2017-04-21 13:57:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:02:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492783030838910, "parent_rev":
"18b7d8c7665b235deb3c3ce84be9c89acaf5549c", "commit_rev":
"402945dae4329cd6e3b2cbeaaf8846818ca92ec5"}

[commit-bot: I haz the power, 2017-04-21 14:02:35]

Description was changed from

==========
AudioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
AudioSystemImpl binding cleanup

BUG=672468
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2828143006
Cr-Commit-Position: refs/heads/master@{#466324}
Committed:
https://chromium.googlesource.com/chromium/src/+/402945dae4329cd6e3b2cbeaaf88...
==========

[commit-bot: I haz the power, 2017-04-21 14:02:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/402945dae4329cd6e3b2cbeaaf88...