Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc

Issue 2827333005: Moving overhead counting to bitrate estimators.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
diff --git a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
index dcec0f8000eca124b0acc066c40ac7278d30a0c1..195244541dd870725bd1c72ca354b43cc6bc5fa2 100644
--- a/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
+++ b/webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc
@@ -19,10 +19,14 @@
namespace webrtc {
namespace {
+
constexpr int kNumProbesCluster0 = 5;
constexpr int kNumProbesCluster1 = 8;
const PacedPacketInfo kPacingInfo0(0, kNumProbesCluster0, 2000);
const PacedPacketInfo kPacingInfo1(1, kNumProbesCluster1, 4000);
+constexpr size_t kRtpHeadersSize = 12;
+constexpr size_t kTransportHeadersSize = 20;
+
} // namespace
TEST_F(DelayBasedBweTest, NoCrashEmptyFeedback) {
@@ -33,9 +37,11 @@ TEST_F(DelayBasedBweTest, NoCrashEmptyFeedback) {
TEST_F(DelayBasedBweTest, NoCrashOnlyLostFeedback) {
std::vector<PacketFeedback> packet_feedback_vector;
packet_feedback_vector.push_back(
- PacketFeedback(-1, -1, 0, 1500, PacedPacketInfo()));
+ PacketFeedback(-1, -1, 0, 1500, kRtpHeadersSize, kTransportHeadersSize,
+ PacedPacketInfo()));
packet_feedback_vector.push_back(
- PacketFeedback(-1, -1, 1, 1500, PacedPacketInfo()));
+ PacketFeedback(-1, -1, 1, 1500, kRtpHeadersSize, kTransportHeadersSize,
+ PacedPacketInfo()));
bitrate_estimator_->IncomingPacketFeedbackVector(packet_feedback_vector);
}

Powered by Google App Engine
This is Rietveld 408576698