chrome/renderer/resources/extensions/web_view_experimental.js - Issue 28273006: <webview>: Implement declarativeWebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view_experimental.js

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/web_view_experimental.js

diff --git a/chrome/renderer/resources/extensions/web_view_experimental.js b/chrome/renderer/resources/extensions/web_view_experimental.js

index 06451ddb957d97cdbc6159ca607e0b959a7a3580..5217a07f3f10983fad366c55b3a2fb2d1049bb3b 100644

--- a/chrome/renderer/resources/extensions/web_view_experimental.js

+++ b/chrome/renderer/resources/extensions/web_view_experimental.js

@@ -30,10 +30,10 @@ var WEB_VIEW_EXPERIMENTAL_EVENTS = {

/**

* @private

-WebViewInternal.prototype.maybeAttachWebRequestEventToWebview_ =

- function(eventName, webRequestEvent) {

+WebViewInternal.prototype.maybeAttachWebRequestEventToObject_ =

+ function(obj, eventName, webRequestEvent) {

Object.defineProperty(

- this.webviewNode_,

+ obj,

eventName,

{

get: webRequestEvent,