chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js - Issue 28273006: <webview>: Implement declarativeWebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js b/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

index 1de43d76c85680df31d5409ef112bb999884c2f6..750468aada791f890c3d2ddea28eb025f4c6c8b0 100644

--- a/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

@@ -34,12 +34,13 @@ function WebRequestEvent(eventName, opt_argSchemas, opt_extraArgSchemas,

this.eventName_ = eventName;

this.argSchemas_ = opt_argSchemas;

this.extraArgSchemas_ = opt_extraArgSchemas;

- this.webViewInstanceId_ = opt_webViewInstanceId ? opt_webViewInstanceId : 0;

+ this.webViewInstanceId_ = opt_webViewInstanceId || 0;

this.subEvents_ = [];

this.eventOptions_ = eventBindings.parseEventOptions(opt_eventOptions);

if (this.eventOptions_.supportsRules) {

this.eventForRules_ =

- new eventBindings.Event(eventName, opt_argSchemas, opt_eventOptions);

+ new eventBindings.Event(eventName, opt_argSchemas, opt_eventOptions,

+ opt_webViewInstanceId);

}

« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/web_view.js » ('j') | no next file with comments »