chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc - Issue 28273006: <webview>: Implement declarativeWebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/declarative_apitest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc

index 12d707dda9adea885ba09d8d0060cbb0143034d4..67ad2a206c13b9a1d10f5cdf58590b824431334d 100644

--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/initializing_rules_registry_unittest.cc

@@ -22,9 +22,10 @@ TEST(InitializingRulesRegistryTest, FillOptionalIdentifiers) {

base::MessageLoopForUI message_loop;

content::TestBrowserThread thread(content::BrowserThread::UI, &message_loop);

+ const RulesRegistry::WebViewKey key(0, 0);

std::string error;

scoped_refptr<RulesRegistry> registry =

- new TestRulesRegistry(content::BrowserThread::UI, "" /*event_name*/);

+ new TestRulesRegistry(content::BrowserThread::UI, "" /*event_name*/, key);

// Add rules and check that their identifiers are filled and unique.

@@ -137,9 +138,10 @@ TEST(InitializingRulesRegistryTest, FillOptionalPriority) {