Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/resources/extensions/web_view_experimental.js

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Istiaque's comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/web_request/web_request_api.h ('K') | « chrome/renderer/resources/extensions/web_view.js ('k') | chrome/renderer/resources/extensions/webview_request_custom_bindings.js » ('j') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/web_view_experimental.js
diff --git a/chrome/renderer/resources/extensions/web_view_experimental.js b/chrome/renderer/resources/extensions/web_view_experimental.js
index ed1103dd2299f4a272f7fd51ce6cf0b5220542a8..c06082aafb5e6ac9868c1a97f788c8377df5d1e3 100644
--- a/chrome/renderer/resources/extensions/web_view_experimental.js
+++ b/chrome/renderer/resources/extensions/web_view_experimental.js
@@ -33,10 +33,10 @@ var WEB_VIEW_EXPERIMENTAL_EVENTS = {
/**
* @private
*/
-WebViewInternal.prototype.maybeAttachWebRequestEventToWebview_ =
- function(eventName, webRequestEvent) {
+WebViewInternal.prototype.maybeAttachWebRequestEventToObject_ =
+ function(obj, eventName, webRequestEvent) {
Object.defineProperty(
- this.webviewNode_,
+ obj,
eventName,
{
get: webRequestEvent,
« chrome/browser/extensions/api/web_request/web_request_api.h ('K') | « chrome/renderer/resources/extensions/web_view.js ('k') | chrome/renderer/resources/extensions/webview_request_custom_bindings.js » ('j') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698