chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 28273006: <webview>: Implement declarativeWebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 28273006: <webview>: Implement declarativeWebRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Istiaque's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc ('k') | chrome/browser/extensions/api/declarative/test_rules_registry.cc » ('j') | chrome/browser/extensions/api/web_request/web_request_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index 141a0ac810c91aa541e83f679fe0a0c0670fcb7f..dee71ddae2fbbbbd52a79515de6f966f1bb604d9 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -229,12 +229,14 @@ TEST_F(RulesRegistryWithCacheTest, DeclarativeRulesStored) {

TestingValueStore* store = system->value_store();

const std::string event_name("testEvent");

+ const RulesRegistry::WebViewKey key(0, 0);

const std::string rules_stored_key(

RulesCacheDelegate::GetRulesStoredKey(

event_name, profile.IsOffTheRecord()));

scoped_ptr<RulesCacheDelegate> cache_delegate(new RulesCacheDelegate(false));

scoped_refptr<RulesRegistry> registry(new TestRulesRegistry(

- &profile, event_name, content::BrowserThread::UI, cache_delegate.get()));

+ &profile, event_name, content::BrowserThread::UI,

+ cache_delegate.get()));

// 1. Test the handling of preferences.

// Default value is always true.

@@ -301,6 +303,7 @@ TEST_F(RulesRegistryWithCacheTest, RulesStoredFlagMultipleRegistries) {

const std::string event_name1("testEvent1");

const std::string event_name2("testEvent2");

+ const RulesRegistry::WebViewKey key(0, 0);

const std::string rules_stored_key1(

RulesCacheDelegate::GetRulesStoredKey(

event_name1, profile.IsOffTheRecord()));

@@ -362,8 +365,7 @@ TEST_F(RulesRegistryWithCacheTest, RulesPreservedAcrossRestart) {

EXPECT_EQ(1, GetNumberOfRules(kExtensionId, registry.get()));

// 3. Restart the TestRulesRegistry and see the rule still there.

- cache_delegate.reset(

- new RulesCacheDelegate(false));

+ cache_delegate.reset(new RulesCacheDelegate(false));

registry = new TestRulesRegistry(

&profile, "testEvent", content::BrowserThread::UI, cache_delegate.get());