Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: call/rampup_tests.cc

Issue 2826263004: Move responsibility for RTP header extensions on video receive. (Closed)
Patch Set: Crude rebase. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « call/flexfec_receive_stream_unittest.cc ('k') | call/video_receive_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: call/rampup_tests.cc
diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc
index 6ce2efd6ac58c14edbff4905c8b9e447729ee064..d7336142dd7ebc90408452e44b84574f708d1330 100644
--- a/call/rampup_tests.cc
+++ b/call/rampup_tests.cc
@@ -196,8 +196,10 @@ void RampUpTester::ModifyVideoConfigs(
for (VideoReceiveStream::Config& recv_config : *receive_configs) {
recv_config.rtp.remb = remb;
recv_config.rtp.transport_cc = transport_cc;
+#if 0
+ // TODO(nisse): Configured for Call instead
recv_config.rtp.extensions = send_config->rtp.extensions;
-
+#endif
recv_config.rtp.remote_ssrc = video_ssrcs_[i];
recv_config.rtp.nack.rtp_history_ms = send_config->rtp.nack.rtp_history_ms;
@@ -272,12 +274,16 @@ void RampUpTester::ModifyFlexfecConfigs(
(*receive_configs)[0].local_ssrc = video_ssrcs_[0];
if (extension_type_ == RtpExtension::kAbsSendTimeUri) {
(*receive_configs)[0].transport_cc = false;
+#if 0
(*receive_configs)[0].rtp_header_extensions.push_back(
RtpExtension(extension_type_.c_str(), kAbsSendTimeExtensionId));
+#endif
} else if (extension_type_ == RtpExtension::kTransportSequenceNumberUri) {
(*receive_configs)[0].transport_cc = true;
+#if 0
(*receive_configs)[0].rtp_header_extensions.push_back(RtpExtension(
extension_type_.c_str(), kTransportSequenceNumberExtensionId));
+#endif
}
}
« no previous file with comments | « call/flexfec_receive_stream_unittest.cc ('k') | call/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698