DialogClientView: Handle nested close requests gracefully.

ui/views/window/dialog_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_client_view.h"
 
 #include <algorithm>
 
 #include "build/build_config.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 69 matching lines @@
   // Doing this now ensures this accelerator will have lower priority than
   // one set by the contents view.
   AddAccelerator(ui::Accelerator(ui::VKEY_ESCAPE, ui::EF_NONE));
   button_row_container_ = new ButtonRowContainer(this);
   AddChildView(button_row_container_);
 }
 
 DialogClientView::~DialogClientView() {}
 
 void DialogClientView::AcceptWindow() {
-  // Only notify the delegate once. See |delegate_allowed_close_|'s comment.
-  if (!delegate_allowed_close_ && GetDialogDelegate()->Accept()) {
-    delegate_allowed_close_ = true;
-    GetWidget()->Close();
-  }
+  CloseWithDelegateMethod(&DialogDelegate::Accept, true);
 }
 
 void DialogClientView::CancelWindow() {
-  // Only notify the delegate once. See |delegate_allowed_close_|'s comment.
-  if (!delegate_allowed_close_ && GetDialogDelegate()->Cancel()) {
-    delegate_allowed_close_ = true;
-    GetWidget()->Close();
-  }
+  CloseWithDelegateMethod(&DialogDelegate::Cancel, true);
 }
 
 void DialogClientView::UpdateDialogButtons() {
   SetupLayout();
   InvalidateLayout();
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // DialogClientView, ClientView overrides:
 
 bool DialogClientView::CanClose() {
+  if (delegate_allowed_close_) {
+    DCHECK(!asking_delegate_whether_to_close_);
+    return true;
+  }
+
+  // The delegate may perform an action that causes the Widget to lose focus and
+  // (for some bubbles) attempt to close again. Widget::Close() has protection
+  // against multiple calls to Widget::Close(), but that method is above
+  // CanClose() in the stack: CanClose() has not yet told the first
+  // Widget::Close() whether it may proceed, so that protection can't be used.
+  // Detect this situation and always return false from the nested call to
+  // CanClose() so that Widget::Close() bails out early.
+  if (asking_delegate_whether_to_close_)
+    return false;
+
   // If the dialog is closing but no Accept or Cancel action has been performed
   // before, it's a Close action.
-  if (!delegate_allowed_close_)
-    delegate_allowed_close_ = GetDialogDelegate()->Close();
+  CloseWithDelegateMethod(&DialogDelegate::Close, false);
   return delegate_allowed_close_;
 }
 
 DialogClientView* DialogClientView::AsDialogClientView() {
   return this;
 }
 
 const DialogClientView* DialogClientView::AsDialogClientView() const {
   return this;
 }
@@ skipping 284 matching lines @@
   UpdateDialogButton(&cancel_button_, ui::DIALOG_BUTTON_CANCEL);
 
   if (extra_view_)
     return;
 
   extra_view_ = GetDialogDelegate()->CreateExtraView();
   if (extra_view_)
     extra_view_->SetGroup(kButtonGroup);
 }
 
+void DialogClientView::CloseWithDelegateMethod(bool (DialogDelegate::*method)(),
+                                               bool close) {
+  DCHECK(!asking_delegate_whether_to_close_);
+
+  // Only notify the delegate once. See |delegate_allowed_close_|'s comment.
+  if (delegate_allowed_close_)
+    return;
+
+  {
+    base::AutoReset<bool> auto_reset(&asking_delegate_whether_to_close_, true);
+    delegate_allowed_close_ = (GetDialogDelegate()->*method)();
+  }
+  if (close && delegate_allowed_close_)
+    GetWidget()->Close();
+}
+
 }  // namespace views