tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 282223004: [Telemetry] Ensure we try to get browser crash stacks everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 282223004: [Telemetry] Ensure we try to get browser crash stacks everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py » ('j') | tools/telemetry/telemetry/core/exceptions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index a574778a6ca01b9c743221342436977986d6f31a..52021ac612cf467db45ddd8dcb10a172b0c1a1df 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -269,8 +269,8 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

except (exceptions.TabCrashException, util.TimeoutException,

IndexError):

retries -= 1

- logging.warn('TabCrashException/TimeoutException in '

- 'new tab creation/navigation, '

- 'remaining retries %d' % retries)

+ logging.warning('TabCrashException/TimeoutException in '

achuithb 2014/05/15 18:10:22 Turns out both warn and warning work :)

+ 'new tab creation/navigation, '

+ 'remaining retries %d', retries)

if not retries:

raise