Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2818593002: Use ChromeJUnit4ClassRunner for javatests in chrome (Closed)

Created:
3 years, 8 months ago by the real yoland
Modified:
3 years, 8 months ago
CC:
aboxhall+watch_chromium.org, agrieve+watch_chromium.org, awdf+watch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dominickn+watch_chromium.org, dougt+watch_chromium.org, David Trainor- moved to gerrit, dtseng+watch_chromium.org, estade+watch_chromium.org, gavinp+prer_chromium.org, gogerald+paymentswatch_chromium.org, jdonnelly+watch_chromium.org, je_julie, lizeb+watch-custom-tabs_chromium.org, mahmadi+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, mlamouri+watch-notifications_chromium.org, nektar+watch_chromium.org, Peter Beverloo, pkotwicz+watch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, sebsg+paymentswatch_chromium.org, sebsg+autofillwatch_chromium.org, tburkard+watch_chromium.org, tfarina, vabr+watchlistautofill_chromium.org, wifiprefetch-reviews_google.com, yuzo+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ChromeJUnit4ClassRunner for javatests in chrome Instrumentation tests in chrome test apk are supposed to run with ChromeJUnit4ClassRunner, for supports on ChromeRestrictionSkipCheck and ChromeDisableIfSkipCheck. BUG=711021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -80 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/IntentHandlerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/TabStateTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkBridgeTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationServiceTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationBuilderBaseTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/VoiceSuggestionProviderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/CurrencyFormatterTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsSectionUnitTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheUMATest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtilsTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerNativeTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/WebsiteAddressTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/ChromeFileProviderTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/util/UrlUtilitiesTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
the real yoland
3 years, 8 months ago (2017-04-12 21:43:47 UTC) #4
Donn Denman
LGTM, and we're seeing a new batch of failures. Hopefully this will fix them too!
3 years, 8 months ago (2017-04-13 00:00:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818593002/1
3 years, 8 months ago (2017-04-13 00:01:34 UTC) #9
jbudorick
3 years, 8 months ago (2017-04-13 00:03:54 UTC) #11 
On 2017/04/13 00:01:34, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Pulling. I don't think that this CL will affect the high rate of failure in
content_shell_test_apk on the L bot.

Powered by Google App Engine
This is Rietveld 408576698