tools/metrics/histograms/histograms.xml - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: . Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index b3f6f5e91b94b3c034097efcb6d401495a767afd..518299407f8913602e0c058a054d3d8ad2dcdacb 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -71881,6 +71881,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SubresourceFilter.PageLoad.FinalURLMatch" units="matches">

+ <owner>melandory@chromium.org</owner>

+ <summary>

+ Records, for each main frame navigation, whether the last URL in the

+ redirect chain matched the Safe Browsing blacklist specified by the

+ histogram suffix.

+ </summary>

+</histogram>

<histogram name="SubresourceFilter.PageLoad.NumSubresourceLoads.Disallowed"

units="resource loads">

<owner>pkalinnikov@chromium.org</owner>

@@ -71934,6 +71943,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"

enum="SubresourceFilterMatchPattern">

+ <obsolete>

+ Obsolete as of April 2017, since the don't have correct data to record

+ anymore.

+ </obsolete>

<owner>melandory@chromium.org</owner>

For each main frame navigation, records a pattern that indicates which URLs

@@ -92148,10 +92161,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<suffix name="SocialEngineeringAdsInterstitial"

label="social eng ad blacklist pattern"/>

- <suffix name="SubresourceFilterOnly" label="subresource filter only patern"/>

+ <suffix name="SubresourceFilterOnly" label="subresource filter only pattern"/>

+ <affected-histogram name="SubresourceFilter.PageLoad.FinalURLMatch"/>

<affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/>

<affected-histogram

- name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/>

+ name="SubresourceFilter.PageLoad.RedirectChainMatchPattern">

+ <obsolete>

+ Obsolete as of April 2017

+ </obsolete>

+ </affected-histogram>

</histogram_suffixes>

<histogram_suffixes name="SyncModelType" separator=".">