DescriptionRevert of media: Simplify CdmHostFile(s) (patchset #4 id:60001 of https://chromiumcodereview.appspot.com/2773283002/ )
Reason for revert:
This issue is in the blame list of issue 708410. Though I don't really see how this could cause that failure, we decided to revert this for now to rule out possibilities. If we confirmed this is not the cause I'll reland it.
BUG=708410
Original issue's description:
> media: Simplify CdmHostFile(s)
>
> Today if any files are missing we close files immediately. This resulted in many complicated logic and requires a special command-line switch for testing.
>
> This CL simplifies the implementation by not treating missing files specially. When a file or a sig file is missing, an invalid file descriptor (e.g. -1 on posix) will be passed to the CDM. The CDM already has logic to deal with this case.
>
> This will also be useful in the future when we explore other ways to verify CDM host files.
>
> BUG=694707
> TEST=Updated browser test.
>
> Review-Url: https://codereview.chromium.org/2773283002
> Cr-Commit-Position: refs/heads/master@{#461193}
> Committed: https://chromium.googlesource.com/chromium/src/+/e23c1b6375d994f06ed745805ba3847e8218cdba
TBR=hmchen@chromium.org,kerrnel@chromium.org,alexmos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=694707
Review-Url: https://codereview.chromium.org/2802853002
Cr-Commit-Position: refs/heads/master@{#462294}
Committed: https://chromium.googlesource.com/chromium/src/+/4dae691b744caea02124a6d3f295c70f5cea9910
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|