Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: extensions/browser/updater/update_service_unittest.cc

Issue 2802433004: ExtensionsTest: Move initialization to SetUp and avoid potential UAF. (Closed)
Patch Set: Avoid UAF. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/updater/update_service_unittest.cc
diff --git a/extensions/browser/updater/update_service_unittest.cc b/extensions/browser/updater/update_service_unittest.cc
index 402ab02369afb2f1f60ab458c53a6813fd5d4c42..3c0390950787d7822c8611fc43be598741f0be2c 100644
--- a/extensions/browser/updater/update_service_unittest.cc
+++ b/extensions/browser/updater/update_service_unittest.cc
@@ -148,10 +148,7 @@ class FakeExtensionSystem : public MockExtensionSystem {
class UpdateServiceTest : public ExtensionsTest {
public:
- UpdateServiceTest() {
- extensions_browser_client()->set_extension_system_factory(
- &fake_extension_system_factory_);
- }
+ UpdateServiceTest() {}
~UpdateServiceTest() override {}
void SetUp() override {
@@ -159,6 +156,8 @@ class UpdateServiceTest : public ExtensionsTest {
browser_threads_.reset(new content::TestBrowserThreadBundle(
content::TestBrowserThreadBundle::DEFAULT));
+ extensions_browser_client()->set_extension_system_factory(
+ &fake_extension_system_factory_);
extensions_browser_client()->SetUpdateClientFactory(base::Bind(
&UpdateServiceTest::CreateUpdateClient, base::Unretained(this)));
« extensions/browser/extensions_test.cc ('K') | « extensions/browser/process_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698