Index: src/compiler/x64/instruction-selector-x64.cc |
diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc |
index 85568a6bd9042ac08282a2b73c4933d551537714..89dc95631828970fcca9954ec019a99acf4a48f8 100644 |
--- a/src/compiler/x64/instruction-selector-x64.cc |
+++ b/src/compiler/x64/instruction-selector-x64.cc |
@@ -2305,7 +2305,7 @@ void InstructionSelector::VisitAtomicExchange(Node* node) { |
Node* index = node->InputAt(1); |
Node* value = node->InputAt(2); |
- MachineType type = AtomicExchangeRepresentationOf(node->op()); |
+ MachineType type = AtomicOpRepresentationOf(node->op()); |
ArchOpcode opcode = kArchNop; |
if (type == MachineType::Int8()) { |
opcode = kAtomicExchangeInt8; |
@@ -2323,7 +2323,7 @@ void InstructionSelector::VisitAtomicExchange(Node* node) { |
} |
InstructionOperand outputs[1]; |
AddressingMode addressing_mode; |
- InstructionOperand inputs[4]; |
+ InstructionOperand inputs[3]; |
size_t input_count = 0; |
inputs[input_count++] = g.UseUniqueRegister(value); |
inputs[input_count++] = g.UseUniqueRegister(base); |
@@ -2346,7 +2346,7 @@ void InstructionSelector::VisitAtomicCompareExchange(Node* node) { |
Node* old_value = node->InputAt(2); |
Node* new_value = node->InputAt(3); |
- MachineType type = AtomicCompareExchangeRepresentationOf(node->op()); |
+ MachineType type = AtomicOpRepresentationOf(node->op()); |
ArchOpcode opcode = kArchNop; |
if (type == MachineType::Int8()) { |
opcode = kAtomicCompareExchangeInt8; |
@@ -2381,6 +2381,63 @@ void InstructionSelector::VisitAtomicCompareExchange(Node* node) { |
Emit(code, 1, outputs, input_count, inputs); |
} |
+void InstructionSelector::VisitAtomicBinaryOperation( |
+ Node* node, ArchOpcode int8_op, ArchOpcode uint8_op, ArchOpcode int16_op, |
+ ArchOpcode uint16_op, ArchOpcode word32_op) { |
+ X64OperandGenerator g(this); |
+ Node* base = node->InputAt(0); |
+ Node* index = node->InputAt(1); |
+ Node* value = node->InputAt(2); |
+ |
+ MachineType type = AtomicOpRepresentationOf(node->op()); |
+ ArchOpcode opcode = kArchNop; |
+ if (type == MachineType::Int8()) { |
+ opcode = int8_op; |
+ } else if (type == MachineType::Uint8()) { |
+ opcode = uint8_op; |
+ } else if (type == MachineType::Int16()) { |
+ opcode = int16_op; |
+ } else if (type == MachineType::Uint16()) { |
+ opcode = uint16_op; |
+ } else if (type == MachineType::Int32() || type == MachineType::Uint32()) { |
+ opcode = word32_op; |
+ } else { |
+ UNREACHABLE(); |
+ return; |
+ } |
+ InstructionOperand outputs[1]; |
+ AddressingMode addressing_mode; |
+ InstructionOperand inputs[3]; |
+ size_t input_count = 0; |
+ inputs[input_count++] = g.UseUniqueRegister(value); |
+ inputs[input_count++] = g.UseUniqueRegister(base); |
+ if (g.CanBeImmediate(index)) { |
+ inputs[input_count++] = g.UseImmediate(index); |
+ addressing_mode = kMode_MRI; |
+ } else { |
+ inputs[input_count++] = g.UseUniqueRegister(index); |
+ addressing_mode = kMode_MR1; |
+ } |
+ outputs[0] = g.DefineAsFixed(node, rax); |
+ InstructionOperand temp[1]; |
+ temp[0] = g.TempRegister(); |
+ InstructionCode code = opcode | AddressingModeField::encode(addressing_mode); |
+ Emit(code, 1, outputs, input_count, inputs, 1, temp); |
+} |
+ |
+#define VISIT_ATOMIC_BINOP(op) \ |
+ void InstructionSelector::VisitAtomic##op(Node* node) { \ |
+ VisitAtomicBinaryOperation(node, kAtomic##op##Int8, kAtomic##op##Uint8, \ |
+ kAtomic##op##Int16, kAtomic##op##Uint16, \ |
+ kAtomic##op##Word32); \ |
+ } |
+VISIT_ATOMIC_BINOP(Add) |
+VISIT_ATOMIC_BINOP(Sub) |
+VISIT_ATOMIC_BINOP(And) |
+VISIT_ATOMIC_BINOP(Or) |
+VISIT_ATOMIC_BINOP(Xor) |
+#undef VISIT_ATOMIC_BINOP |
+ |
#define SIMD_TYPES(V) V(I32x4) |
#define SIMD_ZERO_OP_LIST(V) \ |