Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7981)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 7fac352d2a52a9230489be2b79d120971ba9559c..c347d95ca6199d2212c5df97dd301795cf265749 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -417,12 +417,14 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
@@ -505,12 +507,13 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
@@ -587,12 +590,13 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},

Powered by Google App Engine
This is Rietveld 408576698