Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/process_manager_unittest.cc

Issue 2798503002: Extensions: Pull duplicated functionality into ExtensionsTest fixture. (Closed)
Patch Set: Nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/extensions_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/process_manager_unittest.cc
diff --git a/extensions/browser/process_manager_unittest.cc b/extensions/browser/process_manager_unittest.cc
index 25f6406ddb11ba6f249a2bb6c336548b9f68a1c9..1bc3507653369b0da49876c65441c3dc663f7872 100644
--- a/extensions/browser/process_manager_unittest.cc
+++ b/extensions/browser/process_manager_unittest.cc
@@ -24,19 +24,6 @@ namespace extensions {
namespace {
-// An incognito version of a TestBrowserContext.
-class TestBrowserContextIncognito : public TestBrowserContext {
- public:
- TestBrowserContextIncognito() {}
- ~TestBrowserContextIncognito() override {}
-
- // TestBrowserContext implementation.
- bool IsOffTheRecord() const override { return true; }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(TestBrowserContextIncognito);
-};
-
// A trivial ProcessManagerDelegate.
class TestProcessManagerDelegate : public ProcessManagerDelegate {
public:
@@ -69,7 +56,6 @@ class TestProcessManagerDelegate : public ProcessManagerDelegate {
class ProcessManagerTest : public ExtensionsTest {
public:
ProcessManagerTest() : extension_registry_(browser_context()) {
- extensions_browser_client()->SetIncognitoContext(&incognito_context_);
extensions_browser_client()->set_process_manager_delegate(
&process_manager_delegate_);
}
@@ -78,7 +64,6 @@ class ProcessManagerTest : public ExtensionsTest {
// Use original_context() to make it clear it is a non-incognito context.
BrowserContext* original_context() { return browser_context(); }
- BrowserContext* incognito_context() { return &incognito_context_; }
ExtensionRegistry* extension_registry() { return &extension_registry_; }
TestProcessManagerDelegate* process_manager_delegate() {
return &process_manager_delegate_;
@@ -94,7 +79,6 @@ class ProcessManagerTest : public ExtensionsTest {
}
private:
- TestBrowserContextIncognito incognito_context_;
ExtensionRegistry extension_registry_; // Shared between BrowserContexts.
TestProcessManagerDelegate process_manager_delegate_;
« no previous file with comments | « extensions/browser/extensions_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698