OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "extensions/browser/extensions_test.h" | 5 #include "extensions/browser/extensions_test.h" |
6 | 6 |
| 7 #include "base/memory/ptr_util.h" |
7 #include "components/keyed_service/content/browser_context_dependency_manager.h" | 8 #include "components/keyed_service/content/browser_context_dependency_manager.h" |
| 9 #include "components/pref_registry/pref_registry_syncable.h" |
| 10 #include "components/prefs/pref_service_factory.h" |
| 11 #include "components/prefs/testing_pref_store.h" |
8 #include "content/public/browser/content_browser_client.h" | 12 #include "content/public/browser/content_browser_client.h" |
9 #include "content/public/common/content_client.h" | 13 #include "content/public/common/content_client.h" |
10 #include "content/public/test/test_browser_context.h" | 14 #include "content/public/test/test_browser_context.h" |
| 15 #include "extensions/browser/extension_pref_value_map.h" |
| 16 #include "extensions/browser/extension_prefs.h" |
| 17 #include "extensions/browser/extension_prefs_factory.h" |
11 #include "extensions/browser/test_extensions_browser_client.h" | 18 #include "extensions/browser/test_extensions_browser_client.h" |
12 #include "extensions/test/test_content_browser_client.h" | 19 #include "extensions/test/test_content_browser_client.h" |
13 #include "extensions/test/test_content_utility_client.h" | 20 #include "extensions/test/test_content_utility_client.h" |
14 | 21 |
| 22 namespace { |
| 23 |
| 24 std::unique_ptr<content::TestBrowserContext> CreateTestIncognitoContext() { |
| 25 std::unique_ptr<content::TestBrowserContext> incognito_context = |
| 26 base::MakeUnique<content::TestBrowserContext>(); |
| 27 incognito_context->set_is_off_the_record(true); |
| 28 return incognito_context; |
| 29 } |
| 30 |
| 31 } // namespace |
| 32 |
15 namespace extensions { | 33 namespace extensions { |
16 | 34 |
17 // This class does work in the constructor instead of SetUp() to give subclasses | 35 // This class does work in the constructor instead of SetUp() to give subclasses |
18 // a valid BrowserContext to use while initializing their members. For example: | 36 // a valid BrowserContext to use while initializing their members. For example: |
19 // | 37 // |
20 // class MyExtensionsTest : public ExtensionsTest { | 38 // class MyExtensionsTest : public ExtensionsTest { |
21 // MyExtensionsTest() | 39 // MyExtensionsTest() |
22 // : my_object_(browser_context())) { | 40 // : my_object_(browser_context())) { |
23 // } | 41 // } |
24 // }; | 42 // }; |
| 43 // TODO(crbug.com/708256): All these instances are setup in the constructor, but |
| 44 // destroyed in TearDown(), which may cause problems. Move this initialization |
| 45 // to SetUp(). |
25 ExtensionsTest::ExtensionsTest() | 46 ExtensionsTest::ExtensionsTest() |
26 : content_browser_client_(new TestContentBrowserClient), | 47 : content_browser_client_(new TestContentBrowserClient), |
27 content_utility_client_(new TestContentUtilityClient), | 48 content_utility_client_(new TestContentUtilityClient), |
28 browser_context_(new content::TestBrowserContext), | 49 browser_context_(new content::TestBrowserContext), |
| 50 incognito_context_(CreateTestIncognitoContext()), |
29 extensions_browser_client_( | 51 extensions_browser_client_( |
30 new TestExtensionsBrowserClient(browser_context_.get())) { | 52 new TestExtensionsBrowserClient(browser_context_.get())) { |
31 content::SetBrowserClientForTesting(content_browser_client_.get()); | 53 content::SetBrowserClientForTesting(content_browser_client_.get()); |
32 content::SetUtilityClientForTesting(content_utility_client_.get()); | 54 content::SetUtilityClientForTesting(content_utility_client_.get()); |
33 ExtensionsBrowserClient::Set(extensions_browser_client_.get()); | 55 ExtensionsBrowserClient::Set(extensions_browser_client_.get()); |
34 extensions_browser_client_->set_extension_system_factory( | 56 extensions_browser_client_->set_extension_system_factory( |
35 &extension_system_factory_); | 57 &extension_system_factory_); |
| 58 extensions_browser_client_->SetIncognitoContext(incognito_context_.get()); |
| 59 |
| 60 // Set up all the dependencies of ExtensionPrefs. |
| 61 extension_pref_value_map_.reset(new ExtensionPrefValueMap()); |
| 62 PrefServiceFactory factory; |
| 63 factory.set_user_prefs(new TestingPrefStore()); |
| 64 factory.set_extension_prefs(new TestingPrefStore()); |
| 65 user_prefs::PrefRegistrySyncable* pref_registry = |
| 66 new user_prefs::PrefRegistrySyncable(); |
| 67 // Prefs should be registered before the PrefService is created. |
| 68 ExtensionPrefs::RegisterProfilePrefs(pref_registry); |
| 69 pref_service_ = factory.Create(pref_registry); |
| 70 |
| 71 std::unique_ptr<ExtensionPrefs> extension_prefs(ExtensionPrefs::Create( |
| 72 browser_context(), pref_service_.get(), |
| 73 browser_context()->GetPath().AppendASCII("Extensions"), |
| 74 extension_pref_value_map_.get(), false /* extensions_disabled */, |
| 75 std::vector<ExtensionPrefsObserver*>())); |
| 76 |
| 77 ExtensionPrefsFactory::GetInstance()->SetInstanceForTesting( |
| 78 browser_context(), std::move(extension_prefs)); |
36 } | 79 } |
37 | 80 |
38 ExtensionsTest::~ExtensionsTest() { | 81 ExtensionsTest::~ExtensionsTest() { |
39 ExtensionsBrowserClient::Set(nullptr); | 82 ExtensionsBrowserClient::Set(nullptr); |
40 content::SetBrowserClientForTesting(nullptr); | 83 content::SetBrowserClientForTesting(nullptr); |
41 content::SetUtilityClientForTesting(nullptr); | 84 content::SetUtilityClientForTesting(nullptr); |
42 } | 85 } |
43 | 86 |
44 void ExtensionsTest::SetUp() { | 87 void ExtensionsTest::SetUp() { |
45 // Crashing here? Don't use this class in Chrome's unit_tests. See header. | 88 // Crashing here? Don't use this class in Chrome's unit_tests. See header. |
46 BrowserContextDependencyManager::GetInstance() | 89 BrowserContextDependencyManager::GetInstance() |
47 ->CreateBrowserContextServicesForTest(browser_context_.get()); | 90 ->CreateBrowserContextServicesForTest(browser_context_.get()); |
48 } | 91 } |
49 | 92 |
50 void ExtensionsTest::TearDown() { | 93 void ExtensionsTest::TearDown() { |
51 // Allows individual tests to have BrowserContextKeyedServiceFactory objects | 94 // Allows individual tests to have BrowserContextKeyedServiceFactory objects |
52 // as member variables instead of singletons. The individual services will be | 95 // as member variables instead of singletons. The individual services will be |
53 // cleaned up before the factories are destroyed. | 96 // cleaned up before the factories are destroyed. |
54 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices( | 97 BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices( |
55 browser_context_.get()); | 98 browser_context_.get()); |
| 99 |
| 100 // TODO(crbug.com/708256): |extension_browser_client_| is reset here but not |
| 101 // unset as the singleton until the destructor. This can lead to use after |
| 102 // free errors. |
56 extensions_browser_client_.reset(); | 103 extensions_browser_client_.reset(); |
57 browser_context_.reset(); | 104 browser_context_.reset(); |
| 105 incognito_context_.reset(); |
| 106 pref_service_.reset(); |
58 } | 107 } |
59 | 108 |
60 } // namespace extensions | 109 } // namespace extensions |
OLD | NEW |