[GCM] Run InstanceIDImpl callbacks asynchronously

[GCM] Run InstanceIDImpl callbacks asynchronously

Follow-up on https://codereview.chromium.org/2697793004 review comment.

BUG=none

Review-Url: https://codereview.chromium.org/2789123003
Cr-Commit-Position: refs/heads/master@{#462854}
Committed: https://chromium.googlesource.com/chromium/src/+/2d3155ea0a63b2321b3b3f85d7acb34b3a013895

[johnme, 2017-04-03 17:39:08]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-04-03 17:45:01]

lgtm

https://codereview.chromium.org/2789123003/diff/1/components/gcm_driver/insta...
File components/gcm_driver/instance_id/instance_id_impl.cc (right):

https://codereview.chromium.org/2789123003/diff/1/components/gcm_driver/insta...
components/gcm_driver/instance_id/instance_id_impl.cc:270:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, task);
It's a bit unfortunate that this makes things asynchronous by delaying the
operation rather than posting the response.

The alternative is to update lines 77, 87, 133, 157, 174, 191, 197 and 203 with
PostTask()s. That's a bit fugly too :(

[johnme, 2017-04-03 17:50:44]

https://codereview.chromium.org/2789123003/diff/1/components/gcm_driver/insta...
File components/gcm_driver/instance_id/instance_id_impl.cc (right):

https://codereview.chromium.org/2789123003/diff/1/components/gcm_driver/insta...
components/gcm_driver/instance_id/instance_id_impl.cc:270:
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, task);
On 2017/04/03 17:45:01, Peter Beverloo wrote:
> It's a bit unfortunate that this makes things asynchronous by delaying the
> operation rather than posting the response.
> 
> The alternative is to update lines 77, 87, 133, 157, 174, 191, 197 and 203
with
> PostTask()s. That's a bit fugly too :(

Acknowledged :)

[johnme, 2017-04-03 22:53:40]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 22:54:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 23:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 23:54:36]

Dry run: This issue passed the CQ dry run.

[johnme, 2017-04-05 14:02:28]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 14:02:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:18:27]

Dry run: This issue passed the CQ dry run.

[johnme, 2017-04-06 17:16:29]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:17:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:10:27]

Dry run: This issue passed the CQ dry run.

[johnme, 2017-04-07 10:15:31]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 10:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 10:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 10:19:08]

Dry run: This issue passed the CQ dry run.

[johnme, 2017-04-07 13:09:22]

The CQ bit was checked by johnme@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 13:09:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 13:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:12:19]

Dry run: This issue passed the CQ dry run.

[johnme, 2017-04-07 13:52:44]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-04-07 13:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 14:36:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491573164230590, "parent_rev":
"175d75afa30ba7c98b3c183e21edf233aaa9269f", "commit_rev":
"2d3155ea0a63b2321b3b3f85d7acb34b3a013895"}

[commit-bot: I haz the power, 2017-04-07 14:37:37]

Description was changed from

==========
[GCM] Run InstanceIDImpl callbacks asynchronously

Follow-up on https://codereview.chromium.org/2697793004 review comment.

BUG=none
==========

to

==========
[GCM] Run InstanceIDImpl callbacks asynchronously

Follow-up on https://codereview.chromium.org/2697793004 review comment.

BUG=none

Review-Url: https://codereview.chromium.org/2789123003
Cr-Commit-Position: refs/heads/master@{#462854}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d3155ea0a63b2321b3b3f85d7ac...
==========

[commit-bot: I haz the power, 2017-04-07 14:37:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d3155ea0a63b2321b3b3f85d7ac...