Issue 2785903002: [TTS] Reenable disabled expand test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2785903002: [TTS] Reenable disabled expand test.

Created:
3 years, 8 months ago by Donn Denman

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, twellington+watch_chromium.org, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[TTS] Reenable disabled expand test. Now checking if velocity is equal to zero when skipping the Expand, as suggested by Matt in the bug. BUG=706179

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java	View		1 chunk	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Donn Denman

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

3 years, 8 months ago (2017-03-30 02:48:20 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785903002/1

3 years, 8 months ago (2017-03-30 02:49:12 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-03-30 04:27:38 UTC) #3

commit-bot: I haz the power

3 years, 8 months ago (2017-03-30 04:27:39 UTC) #4

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages