Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2778963002: Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Return EphemeralRange instead of Range in DOMSelection::createRangeFromSelectionEditor BUG=693975 TEST=No change in behavior Review-Url: https://codereview.chromium.org/2778963002 Cr-Commit-Position: refs/heads/master@{#460047} Committed: https://chromium.googlesource.com/chromium/src/+/ec7293736547e92e7f86ab52edebb469b9a5b93c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 3 chunks +17 lines, -14 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
yoichio
3 years, 8 months ago (2017-03-28 03:48:19 UTC) #5
yosin_UTC9
lgtm https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/core/editing/DOMSelection.cpp File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right): https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/core/editing/DOMSelection.cpp#newcode227 third_party/WebKit/Source/core/editing/DOMSelection.cpp:227: if (createRangeFromSelectionEditor().isNotNull()) nit: I prefer using "?:" as ...
3 years, 8 months ago (2017-03-28 07:04:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778963002/1
3 years, 8 months ago (2017-03-28 08:59:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ec7293736547e92e7f86ab52edebb469b9a5b93c
3 years, 8 months ago (2017-03-28 09:21:42 UTC) #13
yoichio
3 years, 8 months ago (2017-03-28 09:32:51 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2778963002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:227: if
(createRangeFromSelectionEditor().isNotNull())
On 2017/03/28 07:04:31, yosin_UTC9 wrote:
> nit: I prefer using "?:" as original
> 
> return createRangeFromSelectionEditor().isNotNull() ? 1 : 0;
New early-return follows above early returns of 1 or 0.

Powered by Google App Engine
This is Rietveld 408576698