Remove TrayAudioDelegate

Remove TrayAudioDelegate

TrayAudioDelegate was needed when Ash was supported on Windows.
Currently, the only implementation is Chrome OS implementation which can
now be inlined wherever the delegate was used.

BUG=664642
TEST=none

Review-Url: https://codereview.chromium.org/2778503002
Cr-Commit-Position: refs/heads/master@{#459963}
Committed: https://chromium.googlesource.com/chromium/src/+/b698a2cc70ef266c593b7515881c0dbf60106a17

[mohsen, 2017-03-24 19:41:07]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 19:41:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-03-24 19:48:03]

mohsen@chromium.org changed reviewers:
+ jamescook@chromium.org

[mohsen, 2017-03-24 19:48:03]

Please take a look...

[commit-bot: I haz the power, 2017-03-24 21:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:13:48]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-03-25 03:45:06]

LGTM! Thanks for taking care of this - it's much easier to reason about the code
without all these extra delegates.

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/audio/tray_audio.h (right):

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/tray_audio.h:10: #include <memory>
nit: not needed

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/audio/volume_view.cc (right):

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/volume_view.cc:59: namespace ash {
nit: move namespace ash:: up above namespace {} and then you don't need all the
ash:: prefixes.

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/volume_view.cc:214:
CrasAudioHandler::Get()->SetOutputVolumePercent(level);
optional: cache CrasAudioHandler* in a local var so you don't have to call Get()
so many times. Might help with line wrapping too.

[mohsen, 2017-03-27 22:21:28]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 22:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-03-27 22:22:18]

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/audio/tray_audio.h (right):

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/tray_audio.h:10: #include <memory>
On 2017/03/25 at 03:45:06, James Cook (OOO) wrote:
> nit: not needed

Removed.

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/audio/volume_view.cc (right):

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/volume_view.cc:59: namespace ash {
On 2017/03/25 at 03:45:06, James Cook (OOO) wrote:
> nit: move namespace ash:: up above namespace {} and then you don't need all
the ash:: prefixes.

Done.

https://codereview.chromium.org/2778503002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/audio/volume_view.cc:214:
CrasAudioHandler::Get()->SetOutputVolumePercent(level);
On 2017/03/25 at 03:45:06, James Cook (OOO) wrote:
> optional: cache CrasAudioHandler* in a local var so you don't have to call
Get() so many times. Might help with line wrapping too.

Done. Here, and in a few other places.

[commit-bot: I haz the power, 2017-03-28 00:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:45:16]

Dry run: This issue passed the CQ dry run.

[mohsen, 2017-03-28 01:04:16]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-03-28 01:04:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2778503002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-03-28 01:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 01:09:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490663056236150,
"parent_rev": "7a72d526a580b3727a91ed5e21a5d4af9fc548b6", "commit_rev":
"b698a2cc70ef266c593b7515881c0dbf60106a17"}

[commit-bot: I haz the power, 2017-03-28 01:10:14]

Description was changed from

==========
Remove TrayAudioDelegate

TrayAudioDelegate was needed when Ash was supported on Windows.
Currently, the only implementation is Chrome OS implementation which can
now be inlined wherever the delegate was used.

BUG=664642
TEST=none
==========

to

==========
Remove TrayAudioDelegate

TrayAudioDelegate was needed when Ash was supported on Windows.
Currently, the only implementation is Chrome OS implementation which can
now be inlined wherever the delegate was used.

BUG=664642
TEST=none

Review-Url: https://codereview.chromium.org/2778503002
Cr-Commit-Position: refs/heads/master@{#459963}
Committed:
https://chromium.googlesource.com/chromium/src/+/b698a2cc70ef266c593b7515881c...
==========

[commit-bot: I haz the power, 2017-03-28 01:10:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b698a2cc70ef266c593b7515881c...