Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: ui/events/blink/input_handler_proxy.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/blink/input_handler_proxy.cc
diff --git a/ui/events/blink/input_handler_proxy.cc b/ui/events/blink/input_handler_proxy.cc
index 20b84d1c4936211dbfaafe0c9ffb4c2fbecbbdee..5f17029cb98046378feaba49cf27ce670e216dd1 100644
--- a/ui/events/blink/input_handler_proxy.cc
+++ b/ui/events/blink/input_handler_proxy.cc
@@ -556,19 +556,20 @@ void InputHandlerProxy::RecordMainThreadScrollingReasons(
// greater than the sample value. kMainThreadScrollingReasonCount doesn't
// include the NotScrollingOnMain enum but the histograms do so adding
// the +1 is necessary.
- uint32_t mainThreadScrollingReasonEnumMax =
+ // TODO(dcheng): Fix https://crbug.com/705169 so this isn't needed.
+ constexpr uint32_t kMainThreadScrollingReasonEnumMax =
cc::MainThreadScrollingReason::kMainThreadScrollingReasonCount + 1;
if (reasons == cc::MainThreadScrollingReason::kNotScrollingOnMain) {
if (device == blink::WebGestureDeviceTouchscreen) {
UMA_HISTOGRAM_ENUMERATION(
kGestureHistogramName,
cc::MainThreadScrollingReason::kNotScrollingOnMain,
- mainThreadScrollingReasonEnumMax);
+ kMainThreadScrollingReasonEnumMax);
} else {
UMA_HISTOGRAM_ENUMERATION(
kWheelHistogramName,
cc::MainThreadScrollingReason::kNotScrollingOnMain,
- mainThreadScrollingReasonEnumMax);
+ kMainThreadScrollingReasonEnumMax);
}
}
@@ -587,10 +588,10 @@ void InputHandlerProxy::RecordMainThreadScrollingReasons(
}
if (device == blink::WebGestureDeviceTouchscreen) {
UMA_HISTOGRAM_ENUMERATION(kGestureHistogramName, i + 1,
- mainThreadScrollingReasonEnumMax);
+ kMainThreadScrollingReasonEnumMax);
} else {
UMA_HISTOGRAM_ENUMERATION(kWheelHistogramName, i + 1,
- mainThreadScrollingReasonEnumMax);
+ kMainThreadScrollingReasonEnumMax);
}
}
}
« base/metrics/histogram_macros_internal.h ('K') | « media/blink/resource_multibuffer_data_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698