Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index c13344e274251e5a7bf12d44eada3de0c2914858..c57e54b348aad43ed4a0319570045cdd936012c0 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -782,28 +782,30 @@ class PeerConnectionUMAObserver : public webrtc::UMAObserver {
int counter_max) override {
switch (counter_type) {
case webrtc::kEnumCounterAddressFamily:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.IPMetrics", counter,
- counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebRTC.PeerConnection.IPMetrics", counter,
+ counter_max);
break;
case webrtc::kEnumCounterIceCandidatePairTypeUdp:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.CandidatePairType_UDP",
- counter, counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR(
+ "WebRTC.PeerConnection.CandidatePairType_UDP", counter,
+ counter_max);
break;
case webrtc::kEnumCounterIceCandidatePairTypeTcp:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.CandidatePairType_TCP",
- counter, counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR(
+ "WebRTC.PeerConnection.CandidatePairType_TCP", counter,
+ counter_max);
break;
case webrtc::kEnumCounterDtlsHandshakeError:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.DtlsHandshakeError",
- counter, counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebRTC.PeerConnection.DtlsHandshakeError",
+ counter, counter_max);
break;
case webrtc::kEnumCounterIceRestart:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.IceRestartState",
- counter, counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebRTC.PeerConnection.IceRestartState",
+ counter, counter_max);
break;
case webrtc::kEnumCounterIceRegathering:
- UMA_HISTOGRAM_ENUMERATION("WebRTC.PeerConnection.IceRegatheringReason",
- counter, counter_max);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebRTC.PeerConnection.IceRegatheringReason",
+ counter, counter_max);
break;
default:
// The default clause is expected to reach when new enum types are

Powered by Google App Engine
This is Rietveld 408576698