Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9504)

Unified Diff: chrome/browser/ui/page_info/page_info.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/page_info/page_info.cc
diff --git a/chrome/browser/ui/page_info/page_info.cc b/chrome/browser/ui/page_info/page_info.cc
index 0d5c53970a9e34c5b7c989ca774222a0a234287a..63002bac6fb22c26dad497eca9ccf8b68dac2b46 100644
--- a/chrome/browser/ui/page_info/page_info.cc
+++ b/chrome/browser/ui/page_info/page_info.cc
@@ -315,11 +315,11 @@ void PageInfo::OnSitePermissionChanged(ContentSettingsType type,
// the Page Info UI.
size_t num_values;
int histogram_value = ContentSettingTypeToHistogramValue(type, &num_values);
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.OriginInfo.PermissionChanged",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.OriginInfo.PermissionChanged",
+ histogram_value, num_values);
if (setting == ContentSetting::CONTENT_SETTING_ALLOW) {
- UMA_HISTOGRAM_ENUMERATION(
+ UMA_HISTOGRAM_EXACT_LINEAR(
"WebsiteSettings.OriginInfo.PermissionChanged.Allowed", histogram_value,
num_values);
@@ -329,7 +329,7 @@ void PageInfo::OnSitePermissionChanged(ContentSettingsType type,
"ContentSettings.Plugins.AddedAllowException", site_url_);
}
} else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) {
- UMA_HISTOGRAM_ENUMERATION(
+ UMA_HISTOGRAM_EXACT_LINEAR(
"WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,
num_values);
}

Powered by Google App Engine
This is Rietveld 408576698