Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 910a331a1e95e65158afd70ec6013de9fc108c91..8b0dd21c2df5b232297c0e0ac79c481b591b9d97 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -855,8 +855,8 @@ void RenderViewContextMenu::RecordUsedItem(int id) {
int enum_id = FindUMAEnumValueForCommand(id, GENERAL_ENUM_ID);
if (enum_id != -1) {
const size_t kMappingSize = arraysize(kUmaEnumToControlId);
- UMA_HISTOGRAM_ENUMERATION("RenderViewContextMenu.Used", enum_id,
- kUmaEnumToControlId[kMappingSize - 1].enum_id);
+ UMA_HISTOGRAM_EXACT_LINEAR("RenderViewContextMenu.Used", enum_id,
+ kUmaEnumToControlId[kMappingSize - 1].enum_id);
// Record to additional context specific histograms.
enum_id = FindUMAEnumValueForCommand(id, CONTEXT_SPECIFIC_ENUM_ID);
@@ -864,23 +864,24 @@ void RenderViewContextMenu::RecordUsedItem(int id) {
if (content_type_->SupportsGroup(ContextMenuContentType::ITEM_GROUP_LINK) &&
content_type_->SupportsGroup(
ContextMenuContentType::ITEM_GROUP_MEDIA_IMAGE)) {
- UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.ImageLink", enum_id,
- kUmaEnumToControlId[kMappingSize - 1].enum_id);
+ UMA_HISTOGRAM_EXACT_LINEAR("ContextMenu.SelectedOption.ImageLink",
+ enum_id,
+ kUmaEnumToControlId[kMappingSize - 1].enum_id);
}
// Selected text context.
if (content_type_->SupportsGroup(
ContextMenuContentType::ITEM_GROUP_SEARCH_PROVIDER) &&
content_type_->SupportsGroup(
ContextMenuContentType::ITEM_GROUP_PRINT)) {
- UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.SelectedText",
- enum_id,
- kUmaEnumToControlId[kMappingSize - 1].enum_id);
+ UMA_HISTOGRAM_EXACT_LINEAR("ContextMenu.SelectedOption.SelectedText",
+ enum_id,
+ kUmaEnumToControlId[kMappingSize - 1].enum_id);
}
// Misspelled word context.
if (!params_.misspelled_word.empty()) {
- UMA_HISTOGRAM_ENUMERATION("ContextMenu.SelectedOption.MisspelledWord",
- enum_id,
- kUmaEnumToControlId[kMappingSize - 1].enum_id);
+ UMA_HISTOGRAM_EXACT_LINEAR("ContextMenu.SelectedOption.MisspelledWord",
+ enum_id,
+ kUmaEnumToControlId[kMappingSize - 1].enum_id);
}
} else {
NOTREACHED() << "Update kUmaEnumToControlId. Unhanded IDC: " << id;
@@ -891,8 +892,8 @@ void RenderViewContextMenu::RecordShownItem(int id) {
int enum_id = FindUMAEnumValueForCommand(id, GENERAL_ENUM_ID);
if (enum_id != -1) {
const size_t kMappingSize = arraysize(kUmaEnumToControlId);
- UMA_HISTOGRAM_ENUMERATION("RenderViewContextMenu.Shown", enum_id,
- kUmaEnumToControlId[kMappingSize - 1].enum_id);
+ UMA_HISTOGRAM_EXACT_LINEAR("RenderViewContextMenu.Shown", enum_id,
+ kUmaEnumToControlId[kMappingSize - 1].enum_id);
} else {
// Just warning here. It's harder to maintain list of all possibly
// visible items than executable items.

Powered by Google App Engine
This is Rietveld 408576698