Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: chrome/browser/content_settings/web_site_settings_uma_util.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/web_site_settings_uma_util.cc
diff --git a/chrome/browser/content_settings/web_site_settings_uma_util.cc b/chrome/browser/content_settings/web_site_settings_uma_util.cc
index 1fa181bbc2493866166738679640ae1bfca3b1b7..2a54150b2e58bfca0992d459296c741f5ab0fc8c 100644
--- a/chrome/browser/content_settings/web_site_settings_uma_util.cc
+++ b/chrome/browser/content_settings/web_site_settings_uma_util.cc
@@ -12,18 +12,18 @@ void WebSiteSettingsUmaUtil::LogPermissionChange(ContentSettingsType type,
ContentSetting setting) {
size_t num_values;
int histogram_value = ContentSettingTypeToHistogramValue(type, &num_values);
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Menu.PermissionChanged",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.Menu.PermissionChanged",
+ histogram_value, num_values);
if (setting == ContentSetting::CONTENT_SETTING_ALLOW) {
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Menu.PermissionChanged.Allowed",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.Menu.PermissionChanged.Allowed",
+ histogram_value, num_values);
} else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) {
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Menu.PermissionChanged.Blocked",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.Menu.PermissionChanged.Blocked",
+ histogram_value, num_values);
} else if (setting == ContentSetting::CONTENT_SETTING_DEFAULT) {
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Menu.PermissionChanged.Reset",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.Menu.PermissionChanged.Reset",
+ histogram_value, num_values);
} else {
NOTREACHED() << "Requested to log permission change " << type << " to "
<< setting;

Powered by Google App Engine
This is Rietveld 408576698