Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2157)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/common/shelf/shelf_view.h

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shelf/shelf_view.cc » ('j') | base/metrics/histogram_macros_internal.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_view.h
diff --git a/ash/common/shelf/shelf_view.h b/ash/common/shelf/shelf_view.h
index 9d4ac100463ae93c51db437a35db4ac764ee2aa9..a96c691d849619dd67aa77a1477324d8203050ba 100644
--- a/ash/common/shelf/shelf_view.h
+++ b/ash/common/shelf/shelf_view.h
@@ -54,10 +54,13 @@ namespace test {
class ShelfViewTestAPI;
}
-extern const int SHELF_ALIGNMENT_UMA_ENUM_VALUE_BOTTOM;
-extern const int SHELF_ALIGNMENT_UMA_ENUM_VALUE_LEFT;
-extern const int SHELF_ALIGNMENT_UMA_ENUM_VALUE_RIGHT;
-extern const int SHELF_ALIGNMENT_UMA_ENUM_VALUE_COUNT;
+enum ShelfAlignmentUmaEnumValue {
+ SHELF_ALIGNMENT_UMA_ENUM_VALUE_BOTTOM,
+ SHELF_ALIGNMENT_UMA_ENUM_VALUE_LEFT,
+ SHELF_ALIGNMENT_UMA_ENUM_VALUE_RIGHT,
+ // Must be last entry in enum.
+ SHELF_ALIGNMENT_UMA_ENUM_VALUE_COUNT,
+};
class ASH_EXPORT ShelfView : public views::View,
public ShelfModelObserver,
« no previous file with comments | « no previous file | ash/common/shelf/shelf_view.cc » ('j') | base/metrics/histogram_macros_internal.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698