Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: ui/gfx/linux/client_native_pixmap_dmabuf.cc

Issue 2774583002: ui: Reduce logging in ui::ClientNativePixmapDmaBuf. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/linux/client_native_pixmap_dmabuf.cc
diff --git a/ui/gfx/linux/client_native_pixmap_dmabuf.cc b/ui/gfx/linux/client_native_pixmap_dmabuf.cc
index 261d086d26b8ecfe71ed1729d181ba04ccdd199c..d656c338f0a6d9eb86e9a3e0a1dd304559d4e28e 100644
--- a/ui/gfx/linux/client_native_pixmap_dmabuf.cc
+++ b/ui/gfx/linux/client_native_pixmap_dmabuf.cc
@@ -47,16 +47,22 @@ void PrimeSyncStart(int dmabuf_fd) {
struct local_dma_buf_sync sync_start = {0};
sync_start.flags = LOCAL_DMA_BUF_SYNC_START | LOCAL_DMA_BUF_SYNC_RW;
- if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start))
- PLOG(ERROR) << "Failed DMA_BUF_SYNC_START";
+#if DCHECK_IS_ON()
+ int rv =
+#endif
+ drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start);
marcheu 2017/03/28 01:07:26 I don't think drmIoctl is meant to be used for non
+ DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_START";
}
void PrimeSyncEnd(int dmabuf_fd) {
struct local_dma_buf_sync sync_end = {0};
sync_end.flags = LOCAL_DMA_BUF_SYNC_END | LOCAL_DMA_BUF_SYNC_RW;
- if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end))
- PLOG(ERROR) << "Failed DMA_BUF_SYNC_END";
+#if DCHECK_IS_ON()
+ int rv =
+#endif
+ drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end);
+ DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_END";
}
} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698