DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps to align icons:
http://imgur.com/a/cYFHm
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
Regarding the binary size of all produced PNG assets, this patch
reduces devtools bundle by ~1.5kb.
BUG=700249
R=dgozman
Review-Url: https://codereview.chromium.org/2772153002
Cr-Commit-Position: refs/heads/master@{#459660}
Committed: https://chromium.googlesource.com/chromium/src/+/7596046bd145df1b871971eb65f3d97c5b752adc
Description was changed from ========== DevTools: re-arrange icons into spritesheets by their size This patch ...
3 years, 9 months ago
(2017-03-25 03:27:57 UTC)
#1
Description was changed from
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps align icons.
Icon extraction is done via the
github.com/aslushnikov/devtools-icon-extractor
Icon re-assembling is handled via the
github.com/aslushnikov/spritesheet-assembler
BUG=700249
R=dgozman
==========
to
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps align icons.
Icon extraction is done via the
http://github.com/aslushnikov/devtools-icon-extractor
BUG=700249
R=dgozman
==========
lushnikov
Description was changed from ========== DevTools: re-arrange icons into spritesheets by their size This patch ...
3 years, 9 months ago
(2017-03-25 03:28:12 UTC)
#2
Description was changed from
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps align icons.
Icon extraction is done via the
http://github.com/aslushnikov/devtools-icon-extractor
BUG=700249
R=dgozman
==========
to
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps align icons.
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
BUG=700249
R=dgozman
==========
lushnikov
Description was changed from ========== DevTools: re-arrange icons into spritesheets by their size This patch ...
3 years, 9 months ago
(2017-03-25 06:20:14 UTC)
#3
Description was changed from
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps align icons.
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
BUG=700249
R=dgozman
==========
to
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps to align icons:
http://imgur.com/a/cYFHm
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
Regarding the binary size of all produced PNG assets, this patch
reduces devtools bundle by ~1.5kb.
BUG=700249
R=dgozman
==========
lushnikov
please, take a look In subsequent changes i'll simplify icon management inside spritesheets.
3 years, 9 months ago
(2017-03-25 06:22:45 UTC)
#4
please, take a look
In subsequent changes i'll simplify icon management inside spritesheets.
lushnikov
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
3 years, 9 months ago
(2017-03-25 06:22:50 UTC)
#5
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/408203)
3 years, 9 months ago
(2017-03-25 08:25:40 UTC)
#8
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/408231)
3 years, 9 months ago
(2017-03-25 12:48:40 UTC)
#12
thanks! https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode89 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:89: // small icons On 2017/03/25 15:45:35, dgozman wrote: ...
3 years, 9 months ago
(2017-03-25 18:51:22 UTC)
#14
thanks!
https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):
https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:89: // small icons
On 2017/03/25 15:45:35, dgozman wrote:
> Kind of useless comment - all the icons below start with smallicon :-)
Not very useful, I agree. Though since in this patch we have "smallicons" in
"mediumicons" it does make sense.
I'll kill the comments in subsequent patches
https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:122:
'smallicon-arrow-in-circle': {x: -34, y: -18, width: 11, height: 11,
spritesheet: 'mediumicons', isMask: true},
On 2017/03/25 15:45:35, dgozman wrote:
> We should rename these.
Right, the following patch does this
https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:198:
'mediumicon-arrow-top': {x: 0, y: 0, width: 19, height: 19, spritesheet:
'arrowicons'},
On 2017/03/25 15:45:35, dgozman wrote:
> And these.
An ideal solution would be to port them over into medium icons.
lushnikov
The CQ bit was checked by lushnikov@chromium.org
3 years, 9 months ago
(2017-03-25 18:51:29 UTC)
#15
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490467889848860, "parent_rev": "c654a79ce1533215e2dcad41d5e623d8220d2dd9", "commit_rev": "7596046bd145df1b871971eb65f3d97c5b752adc"}
3 years, 9 months ago
(2017-03-25 22:42:14 UTC)
#17
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490467889848860, "parent_rev":
"c654a79ce1533215e2dcad41d5e623d8220d2dd9", "commit_rev":
"7596046bd145df1b871971eb65f3d97c5b752adc"}
commit-bot: I haz the power
Description was changed from ========== DevTools: re-arrange icons into spritesheets by their size This patch ...
3 years, 9 months ago
(2017-03-25 22:43:01 UTC)
#18
Message was sent while issue was closed.
Description was changed from
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps to align icons:
http://imgur.com/a/cYFHm
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
Regarding the binary size of all produced PNG assets, this patch
reduces devtools bundle by ~1.5kb.
BUG=700249
R=dgozman
==========
to
==========
DevTools: re-arrange icons into spritesheets by their size
This patch re-arranges icons into spritesheets by their sizes.
Instead of having three spritesheets:
- smallIcons.svg
- resourceGlyphs.svg
- toolbarButtonGlyphs.svg
We now have another three spritesheets, where icons are put
according to their size:
- smallIcons.svg - 10x10 icons
- mediumIcons.svg - 16x16 icons
- largeIcons.svg - 28x24 icons
Each svg spritesheet has a nice grid which helps to align icons:
http://imgur.com/a/cYFHm
Icon extraction and re-assembling is done via the
http://github.com/aslushnikov/devtools-icon-extractor
Regarding the binary size of all produced PNG assets, this patch
reduces devtools bundle by ~1.5kb.
BUG=700249
R=dgozman
Review-Url: https://codereview.chromium.org/2772153002
Cr-Commit-Position: refs/heads/master@{#459660}
Committed:
https://chromium.googlesource.com/chromium/src/+/7596046bd145df1b871971eb65f3...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7596046bd145df1b871971eb65f3d97c5b752adc
3 years, 9 months ago
(2017-03-25 22:43:02 UTC)
#19
Issue 2772153002: DevTools: re-arrange icons into spritesheets by their size
(Closed)
Created 3 years, 9 months ago by lushnikov
Modified 3 years, 9 months ago
Reviewers: dgozman
Base URL:
Comments: 6