Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2772153002: DevTools: re-arrange icons into spritesheets by their size (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: re-arrange icons into spritesheets by their size This patch re-arranges icons into spritesheets by their sizes. Instead of having three spritesheets: - smallIcons.svg - resourceGlyphs.svg - toolbarButtonGlyphs.svg We now have another three spritesheets, where icons are put according to their size: - smallIcons.svg - 10x10 icons - mediumIcons.svg - 16x16 icons - largeIcons.svg - 28x24 icons Each svg spritesheet has a nice grid which helps to align icons: http://imgur.com/a/cYFHm Icon extraction and re-assembling is done via the http://github.com/aslushnikov/devtools-icon-extractor Regarding the binary size of all produced PNG assets, this patch reduces devtools bundle by ~1.5kb. BUG=700249 R=dgozman Review-Url: https://codereview.chromium.org/2772153002 Cr-Commit-Position: refs/heads/master@{#459660} Committed: https://chromium.googlesource.com/chromium/src/+/7596046bd145df1b871971eb65f3d97c5b752adc

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+3010 lines, -2237 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/largeIcons.png View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/largeIcons_2x.png View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/mediumIcons.png View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/mediumIcons_2x.png View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/resourceGlyphs.png View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/resourceGlyphs_2x.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png View Binary file 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/src/largeIcons.svg View 1 chunk +1672 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/Images/src/mediumIcons.svg View 1 chunk +437 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/src/resourceGlyphs.svg View 1 chunk +0 lines, -156 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg View 2 chunks +767 lines, -667 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 1 chunk +0 lines, -1281 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png View Binary file 0 comments Download
D third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +106 lines, -105 lines 6 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 2 chunks +18 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
lushnikov
please, take a look In subsequent changes i'll simplify icon management inside spritesheets.
3 years, 9 months ago (2017-03-25 06:22:45 UTC) #4
dgozman
lgtm! https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode89 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:89: // small icons Kind of useless comment - ...
3 years, 9 months ago (2017-03-25 15:45:35 UTC) #13
lushnikov
thanks! https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2772153002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode89 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:89: // small icons On 2017/03/25 15:45:35, dgozman wrote: ...
3 years, 9 months ago (2017-03-25 18:51:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772153002/1
3 years, 9 months ago (2017-03-25 18:51:44 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 22:43:02 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7596046bd145df1b871971eb65f3...

Powered by Google App Engine
This is Rietveld 408576698