Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 2770833003: [Chromecast] Apply exclude_unwind_tables for appropriate builds (Closed)

Created:
3 years, 9 months ago by halliwell
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke, slan, bcf
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Apply exclude_unwind_tables for appropriate builds This reduces our installed APK size from ~90MB to 65 on ATV. It reduces earth OTA size by 1.5MB and earth cast_shell size by 5MB. Leave unwind tables for builds where we regularly use a debugger (x86 and ATV debug). BUG=internal b/36082628 Review-Url: https://codereview.chromium.org/2770833003 Cr-Commit-Position: refs/heads/master@{#459619} Committed: https://chromium.googlesource.com/chromium/src/+/a13b58bb24fb7bc0bbc7d68296ef11a64df4989e

Patch Set 1 #

Patch Set 2 : Exclude all debug builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
halliwell
3 years, 9 months ago (2017-03-23 13:29:44 UTC) #3
bcf
Personally, I use gdb on device quite a lot so I'm not sure 1.5MB is ...
3 years, 9 months ago (2017-03-23 18:27:22 UTC) #4
halliwell
On 2017/03/23 18:27:22, bcf wrote: > Personally, I use gdb on device quite a lot ...
3 years, 9 months ago (2017-03-23 18:45:22 UTC) #5
slan
LGTM, this matches what we're already doing with symbol_level.
3 years, 9 months ago (2017-03-23 19:29:26 UTC) #6
bcf
lgtm
3 years, 9 months ago (2017-03-23 19:38:28 UTC) #7
halliwell
On 2017/03/23 19:38:28, bcf wrote: > lgtm dpranke: PTAL.
3 years, 9 months ago (2017-03-24 14:27:42 UTC) #8
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-24 21:16:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770833003/20001
3 years, 9 months ago (2017-03-24 21:47:49 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 01:52:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a13b58bb24fb7bc0bbc7d68296ef...

Powered by Google App Engine
This is Rietveld 408576698