Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Issue 2770153002: MD Settings: fix input label floating around for search field. (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/settings_subpage_search.html
diff --git a/chrome/browser/resources/settings/settings_page/settings_subpage_search.html b/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
index c5b46c9db105e6eb0c4b7c76c55ee705e303db5a..c3aacac5b94678c9b27753da82381c882654b69e 100644
--- a/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
+++ b/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
@@ -25,17 +25,6 @@
/* Required to align the icon in |clearSearch| vertically. */
line-height: 0;
};
-
- /**
- * Kind of suck to have to hardcode these, but its necessary to
- * make sure the conditional clear-icon will fit within input's height.
- */
- --paper-input-container-input: {
- line-height: 24px;
- };
- --paper-input-container-label: {
- line-height: 24px;
- };
}
paper-icon-button {
@@ -62,17 +51,9 @@
-webkit-appearance: none;
}
- #prompt,
#searchInput {
font-size: 92.3076923%; /* To 12px from 13px. */
- }
-
- #prompt {
- color: var(--paper-grey-600);
- }
-
- :host([has-search-text]) #prompt {
- visibility: hidden;
+ min-height: 24px;
}
#searchInput {
@@ -86,10 +67,9 @@
</style>
<iron-icon id="searchIcon" icon="cr:search"></iron-icon>
<paper-input-container no-label-float>
- <label id="prompt">[[label]]</label>
<input id="searchInput" type="search" on-search="onSearchTermSearch"
on-input="onSearchTermInput" aria-labelledby="prompt" incremental
- autofocus$="[[autofocus]]">
+ autofocus$="[[autofocus]]" placeholder="[[label]]">
<paper-icon-button suffix icon="cr:cancel" id="clearSearch"
on-tap="onTapClear_" title="[[clearLabel]]"
hidden$="[[!hasSearchText]]">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698