Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2769293002: [MD Extensions] Include the manifest code snippet in load errors (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, srahim+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Extensions] Include the manifest code snippet in load errors Add the manifest code snippet to errors displayed when loading an unpacked extension fails. Add tests for the same. Update Service to display the load error dialog when a load error occurs. BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2769293002 Cr-Commit-Position: refs/heads/master@{#459636} Committed: https://chromium.googlesource.com/chromium/src/+/5370ad38ca596fffee45ffff85a74fda142b5a07

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : . #

Total comments: 16

Patch Set 4 : Michael's #

Patch Set 5 : rm code_section from compiled_resources #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -24 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/code_section.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_extensions/code_section.js View 1 2 3 2 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_extensions/compiled_resources2.gyp View 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_extensions/error_page.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_extensions/load_error.html View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_extensions/load_error.js View 1 2 3 4 2 chunks +25 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_extensions/service.js View 1 2 3 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/webui/extensions/cr_extensions_browsertest.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/data/webui/extensions/extension_code_section_test.js View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/extensions/extension_load_error_test.js View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Devlin
Michael, mind taking a look?
3 years, 9 months ago (2017-03-23 22:21:50 UTC) #4
michaelpg
https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/code_section.js File chrome/browser/resources/md_extensions/code_section.js (right): https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/code_section.js#newcode27 chrome/browser/resources/md_extensions/code_section.js:27: noCodeError: String, I might just be silly, but I'm ...
3 years, 9 months ago (2017-03-24 02:59:02 UTC) #5
Devlin
https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/code_section.js File chrome/browser/resources/md_extensions/code_section.js (right): https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/code_section.js#newcode27 chrome/browser/resources/md_extensions/code_section.js:27: noCodeError: String, On 2017/03/24 02:59:01, michaelpg wrote: > I ...
3 years, 9 months ago (2017-03-24 16:03:08 UTC) #6
michaelpg
lgtm https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/compiled_resources2.gyp File chrome/browser/resources/md_extensions/compiled_resources2.gyp (right): https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/compiled_resources2.gyp#newcode121 chrome/browser/resources/md_extensions/compiled_resources2.gyp:121: 'code_section', On 2017/03/24 16:03:08, Devlin wrote: > On ...
3 years, 9 months ago (2017-03-24 21:25:32 UTC) #7
Devlin
https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/compiled_resources2.gyp File chrome/browser/resources/md_extensions/compiled_resources2.gyp (right): https://codereview.chromium.org/2769293002/diff/40001/chrome/browser/resources/md_extensions/compiled_resources2.gyp#newcode121 chrome/browser/resources/md_extensions/compiled_resources2.gyp:121: 'code_section', On 2017/03/24 21:25:32, michaelpg wrote: > On 2017/03/24 ...
3 years, 9 months ago (2017-03-25 01:58:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769293002/100001
3 years, 9 months ago (2017-03-25 01:58:30 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 03:45:51 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/5370ad38ca596fffee45ffff85a7...

Powered by Google App Engine
This is Rietveld 408576698