Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2768923005: [Sync] Adding missing DependsOn to *ProfileSyncServiceFactory. (Closed)

Created:
3 years, 9 months ago by skym
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Adding missing DependsOn to *ProfileSyncServiceFactory. It looks like most of the recently added model types have not been adding their associated KeyedService dependencies to *ProfileSyncServiceFactory. This change updates the dependencies to include everything used by both *ProfileSyncServiceFactory and *ChromeSyncClient, along with some alphabetization for the ios DependOn()s. Couldn't add a dependency to SupervisedUserServiceFactory because it apparently already depends on ProfileSyncServiceFactory, so added TODOs to fix this. BUG=701326 Review-Url: https://codereview.chromium.org/2768923005 Cr-Commit-Position: refs/heads/master@{#460133} Committed: https://chromium.googlesource.com/chromium/src/+/31da0bbe6ad57750e8821aec9380a0dcd3ce0f54

Patch Set 1 #

Patch Set 2 : Added gcm, removed circular dependency DependsOn, updated doc. #

Patch Set 3 : This time with less incorrect namespace. #

Patch Set 4 : Wrapped some supervised user deps in not android flags, added flag closing comments. #

Total comments: 1

Patch Set 5 : Added crbug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -35 lines) Patch
M chrome/browser/supervised_user/supervised_user_service_factory.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 1 2 3 18 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 2 3 4 4 chunks +38 lines, -4 lines 0 comments Download
M docs/sync/model_api.md View 1 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 1 2 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 38 (22 generated)
skym
PTAL
3 years, 9 months ago (2017-03-24 23:03:38 UTC) #13
pavely
lgtm
3 years, 9 months ago (2017-03-24 23:21:17 UTC) #14
skym
Adding treib@ for supervised_user/ ... Sorry for the hassle, it's just a comment.
3 years, 9 months ago (2017-03-25 03:11:46 UTC) #18
Marc Treib
On 2017/03/25 03:11:46, skym wrote: > Adding treib@ for supervised_user/ ... Sorry for the hassle, ...
3 years, 8 months ago (2017-03-27 08:13:40 UTC) #19
brian.w.petroski
lgtm Fix Google sync
3 years, 8 months ago (2017-03-27 09:08:18 UTC) #21
brian.w.petroski
lgtm Fix Google sync
3 years, 8 months ago (2017-03-27 09:08:22 UTC) #22
sdefresne
https://codereview.chromium.org/2768923005/diff/60001/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc File ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc (right): https://codereview.chromium.org/2768923005/diff/60001/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc#newcode98 ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc:98: // The ProfileSyncService depends on various SyncableServices being around ...
3 years, 8 months ago (2017-03-27 15:34:06 UTC) #25
skym
On 2017/03/27 08:13:40, Marc Treib wrote: > On 2017/03/25 03:11:46, skym wrote: > > Adding ...
3 years, 8 months ago (2017-03-27 15:45:55 UTC) #26
skym
On 2017/03/27 15:34:06, sdefresne wrote: > https://codereview.chromium.org/2768923005/diff/60001/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc > File ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc (right): > > https://codereview.chromium.org/2768923005/diff/60001/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc#newcode98 > ...
3 years, 8 months ago (2017-03-27 15:56:09 UTC) #27
Marc Treib
On 2017/03/27 15:45:55, skym wrote: > On 2017/03/27 08:13:40, Marc Treib wrote: > > On ...
3 years, 8 months ago (2017-03-27 16:53:18 UTC) #28
skym
On 2017/03/27 16:53:18, Marc Treib wrote: > On 2017/03/27 15:45:55, skym wrote: > > On ...
3 years, 8 months ago (2017-03-27 17:01:45 UTC) #29
Marc Treib
On 2017/03/27 17:01:45, skym wrote: > On 2017/03/27 16:53:18, Marc Treib wrote: > > On ...
3 years, 8 months ago (2017-03-28 08:26:57 UTC) #30
sdefresne
On 2017/03/27 15:56:09, skym wrote: > On 2017/03/27 15:34:06, sdefresne wrote: > > > https://codereview.chromium.org/2768923005/diff/60001/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc ...
3 years, 8 months ago (2017-03-28 12:01:08 UTC) #31
skym
On 2017/03/28 12:01:08, sdefresne wrote: > On 2017/03/27 15:56:09, skym wrote: > > On 2017/03/27 ...
3 years, 8 months ago (2017-03-28 15:27:09 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768923005/80001
3 years, 8 months ago (2017-03-28 15:27:49 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:53:14 UTC) #38
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/31da0bbe6ad57750e8821aec9380...

Powered by Google App Engine
This is Rietveld 408576698