Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: extensions/browser/preload_check_test_util.cc

Issue 2768723002: Update ExtensionInstallChecker to use PreloadCheck classes (Closed)
Patch Set: remove redundant DCHECKs that fail in tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/preload_check_test_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/preload_check_test_util.cc
diff --git a/extensions/browser/preload_check_test_util.cc b/extensions/browser/preload_check_test_util.cc
index b12bc17950de05927ec82b86c69a8736e5b65232..f5becf43ae4a7173c854c744f33c495fd2992565 100644
--- a/extensions/browser/preload_check_test_util.cc
+++ b/extensions/browser/preload_check_test_util.cc
@@ -9,10 +9,14 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "extensions/common/extension.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
+// PreloadCheckRunner:
PreloadCheckRunner::PreloadCheckRunner() : called_(false) {}
PreloadCheckRunner::~PreloadCheckRunner() {}
@@ -47,4 +51,36 @@ void PreloadCheckRunner::WaitForIdle() {
run_loop_->RunUntilIdle();
}
+// PreloadCheckStub:
+PreloadCheckStub::PreloadCheckStub()
+ : PreloadCheck(nullptr), is_async_(false), weak_ptr_factory_(this) {}
+
+PreloadCheckStub::~PreloadCheckStub() {}
+
+void PreloadCheckStub::AddError(Error error) {
+ errors_.insert(error);
+}
+
+void PreloadCheckStub::Start(ResultCallback callback) {
+ DCHECK(!callback.is_null());
+ if (is_async_) {
+ // TODO(michaelpg): Bind the callback directly and remove RunCallback
+ // once crbug.com/704027 is addressed.
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
+ FROM_HERE,
+ base::Bind(&PreloadCheckStub::RunCallback,
+ weak_ptr_factory_.GetWeakPtr(), base::Passed(&callback)));
+ } else {
+ std::move(callback).Run(errors_);
+ }
+}
+
+void PreloadCheckStub::RunCallback(ResultCallback callback) {
+ std::move(callback).Run(errors_);
+}
+
+base::string16 PreloadCheckStub::GetErrorMessage() const {
+ return message_;
+}
+
} // namespace extensions
« no previous file with comments | « extensions/browser/preload_check_test_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698