Remove SandboxIPCProcess's dependency on chrome-sandbox

Remove SandboxIPCProcess's dependency on chrome-sandbox

Now that we use RecvMsgWithPid to find the PIDs for zygote children,
we no longer need to plumb the chrome-sandbox path down into and
through the renderer host code.

BUG=357670
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269530

[mdempsky, 2014-05-08 22:52:34]

Now that we don't need the FindChildWithInode IPC anymore, I figure we should at
least disable it, and it was easy enough to remove completely that I decided to
do that.  Let me know if you're worried about issues rolling it back (e.g., if
we end up needing to revert the SCM_CREDENTIALS stuff), and I can do something
less invasive.

[jln (very slow on Chromium), 2014-05-09 00:01:28]

lgtm

As discussed in person, the basic ZygoteId part of this has been in dev for a
week, so I'm not too worried.

https://chromiumcodereview.appspot.com/276763002/diff/1/content/common/sandbo...
File content/common/sandbox_linux/sandbox_linux.h (right):

https://chromiumcodereview.appspot.com/276763002/diff/1/content/common/sandbo...
content/common/sandbox_linux/sandbox_linux.h:33: // unused = 34, (was
METHOD_GET_CHILD_WITH_INODE)
How about just renaming it to DEPRECATED_METHOD_...?

[mdempsky, 2014-05-09 00:04:30]

https://codereview.chromium.org/276763002/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/sandbox_linux.h (right):

https://codereview.chromium.org/276763002/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/sandbox_linux.h:33: // unused = 34, (was
METHOD_GET_CHILD_WITH_INODE)
On 2014/05/09 00:01:28, jln wrote:
> How about just renaming it to DEPRECATED_METHOD_...?

Done.

[mdempsky, 2014-05-09 00:06:42]

sky: Please review tiny change to content/browser/browser_main_loop.cc for
OWNERS approval. Thanks!

[sky, 2014-05-09 13:54:57]

LGTM

[mdempsky, 2014-05-09 16:40:41]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-05-09 16:43:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276763002/20001

[commit-bot: I haz the power, 2014-05-09 23:34:37]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[mdempsky, 2014-05-09 23:52:25]

The CQ bit was unchecked by mdempsky@chromium.org

[mdempsky, 2014-05-09 23:52:32]

The CQ bit was checked by mdempsky@chromium.org

[mdempsky, 2014-05-09 23:53:05]

On 2014/05/09 23:52:32, mdempsky wrote:
> The CQ bit was checked by mailto:mdempsky@chromium.org

Using NOTRY=true to work around slow, useless Windows bots.

[commit-bot: I haz the power, 2014-05-09 23:57:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276763002/20001

[commit-bot: I haz the power, 2014-05-10 04:50:16]

Change committed as 269530