[Devtools] Add SHA-1 hash function in prep for URL hashing

[Devtools] Add SHA-1 hash function in prep for URL hashing

This patch simply adds SHA-1 string hashing for product registry lookup.

R=alph,caseq
BUG=703762
Review-Url: https://codereview.chromium.org/2766823002
Cr-Commit-Position: refs/heads/master@{#459699}
Committed: https://chromium.googlesource.com/chromium/src/+/fe22ae6b4a2c4b0989efb3c8ea8035b62431c9e7

[allada, 2017-03-21 19:13:31]

PTL - A follow up patch will use this function. I am looking for an "ok" on
bringing in SHA-1 this way.

[caseq, 2017-03-22 23:56:42]

I'm generally fine, but let's add a basic test for it and keep the original
copyright.

https://codereview.chromium.org/2766823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/product_registry/sha1.js
(right):

https://codereview.chromium.org/2766823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/sha1.js:1: //
Copyright 2017 The Chromium Authors. All rights reserved.
Please just keep the original copyright.

[alph, 2017-03-23 00:49:06]

We usually don't land unused code.
If you still want to keep it separate from the network part, please don't land
this until the other part is approved.

[allada, 2017-03-23 01:23:30]

On 2017/03/23 00:49:06, alph wrote:
> We usually don't land unused code.
> If you still want to keep it separate from the network part, please don't land
> this until the other part is approved.

Yes, that was the plan.

[allada, 2017-03-23 01:26:16]

https://codereview.chromium.org/2766823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/product_registry/sha1.js
(right):

https://codereview.chromium.org/2766823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/product_registry/sha1.js:1: //
Copyright 2017 The Chromium Authors. All rights reserved.
On 2017/03/22 23:56:42, caseq wrote:
> Please just keep the original copyright.

Done.

[caseq, 2017-03-24 19:31:18]

Since we're doing local modifications to the third-party code, let's put it into
a separate directory and add README.chromium describing the changes.

https://codereview.chromium.org/2766823002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/sha1.html (right):

https://codereview.chromium.org/2766823002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sha1.html:9:
self.runtime.loadModulePromise('product_registry').then(() => {
nit:

function initialize_ProductRegistry() {
    InspectorTest.preloadModule("product_registry");
}

... then just use ProductRegistry straight away in the test.

[allada, 2017-03-25 00:02:07]

PTaL

[allada, 2017-03-25 00:02:11]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 00:02:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2017-03-25 00:14:54]

lgtm

[commit-bot: I haz the power, 2017-03-25 02:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 02:08:12]

Dry run: This issue passed the CQ dry run.

[allada, 2017-03-27 00:00:00]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-03-27 00:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 03:44:06]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490572800718240,
"parent_rev": "843ecf04f4af01faed28fdbb92db683944a06918", "commit_rev":
"fe22ae6b4a2c4b0989efb3c8ea8035b62431c9e7"}

[commit-bot: I haz the power, 2017-03-27 03:45:15]

Description was changed from

==========
[Devtools] Add SHA-1 hash function in prep for URL hashing

This patch simply adds SHA-1 string hashing for product registry lookup.

R=alph,caseq
BUG=703762
==========

to

==========
[Devtools] Add SHA-1 hash function in prep for URL hashing

This patch simply adds SHA-1 string hashing for product registry lookup.

R=alph,caseq
BUG=703762

Review-Url: https://codereview.chromium.org/2766823002
Cr-Commit-Position: refs/heads/master@{#459699}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe22ae6b4a2c4b0989efb3c8ea80...
==========

[commit-bot: I haz the power, 2017-03-27 03:45:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/fe22ae6b4a2c4b0989efb3c8ea80...