Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: net/android/cellular_signal_strength.h

Issue 2763853002: Use Android callback API to obtain cellular signal strength (Closed)
Patch Set: comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/android/cellular_signal_strength.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/cellular_signal_strength.h
diff --git a/net/android/cellular_signal_strength.h b/net/android/cellular_signal_strength.h
index 4165a73da782acd0e38ba19bbd5dec5daba87f5d..e87c9a799284e2216a966c4c84115647edbd8eee 100644
--- a/net/android/cellular_signal_strength.h
+++ b/net/android/cellular_signal_strength.h
@@ -8,7 +8,7 @@
#include <jni.h>
#include <stdint.h>
-#include "base/compiler_specific.h"
+#include "base/optional.h"
#include "net/base/net_export.h"
namespace net {
@@ -17,18 +17,10 @@ namespace android {
namespace cellular_signal_strength {
-// Returns true if the signal strength (in dbM) of the currently registered
-// cellular connection is available, and sets |*signal_strength_dbm| to that
-// value.
-NET_EXPORT bool GetSignalStrengthDbm(int32_t* signal_strength_dbm)
- WARN_UNUSED_RESULT;
-
-// Returns true if the signal strength level (between 0 and 4, both inclusive)
-// of the currently registered cellular connection is available, and sets
-// |*signal_strength_level| to that value with lower value indicating lower
-// signal strength.
-NET_EXPORT bool GetSignalStrengthLevel(int32_t* signal_strength_level)
- WARN_UNUSED_RESULT;
+// Returns the signal strength level (between 0 and 4, both inclusive) of the
+// currently registered cellular connection. If the value is unavailable, an
+// empty value is returned.
+NET_EXPORT_PRIVATE base::Optional<int32_t> GetSignalStrengthLevel();
} // namespace cellular_signal_strength
« no previous file with comments | « no previous file | net/android/cellular_signal_strength.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698