 Chromium Code Reviews
 Chromium Code Reviews Issue 2760723002:
  Check X509Certificate::CreateFromHandle result.  (Closed)
    
  
    Issue 2760723002:
  Check X509Certificate::CreateFromHandle result.  (Closed) 
  | Index: net/cert/cert_verify_proc_mac.cc | 
| diff --git a/net/cert/cert_verify_proc_mac.cc b/net/cert/cert_verify_proc_mac.cc | 
| index f31e4023b195faf719dd72be9414c052f9dcce6a..9d5043b165cf92643bd7cd9752855ddb42099b0c 100644 | 
| --- a/net/cert/cert_verify_proc_mac.cc | 
| +++ b/net/cert/cert_verify_proc_mac.cc | 
| @@ -197,11 +197,16 @@ void CopyCertChainToVerifyResult(CFArrayRef cert_chain, | 
| } | 
| if (!verified_cert) { | 
| NOTREACHED(); | 
| + verify_result->cert_status |= CERT_STATUS_INVALID; | 
| 
eroman
2017/03/24 22:07:23
same comment as for ios
 | 
| return; | 
| } | 
| - verify_result->verified_cert = | 
| + scoped_refptr<X509Certificate> verified_cert_with_chain = | 
| X509Certificate::CreateFromHandle(verified_cert, verified_chain); | 
| + if (verified_cert_with_chain) | 
| + verify_result->verified_cert = std::move(verified_cert_with_chain); | 
| + else | 
| + verify_result->cert_status |= CERT_STATUS_INVALID; | 
| } | 
| // Returns true if the certificate uses MD2, MD4, MD5, or SHA1, and false |