Make X509Certificate creation fail if X509Certificate::Initialize fails.

net/cert/x509_certificate_nss.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cert.h>
 #include <cryptohi.h>
 #include <keyhi.h>
 #include <nss.h>
 #include <pk11pub.h>
 #include <prtime.h>
 #include <seccomon.h>
 #include <secder.h>
 #include <sechash.h>
 
 #include <memory>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/pickle.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "crypto/nss_util.h"
 #include "crypto/scoped_nss_types.h"
 #include "net/cert/x509_certificate.h"
 #include "net/cert/x509_util_nss.h"
 
 namespace net {
 
-void X509Certificate::Initialize() {
-  x509_util::ParsePrincipal(&cert_handle_->subject, &subject_);
-  x509_util::ParsePrincipal(&cert_handle_->issuer, &issuer_);
+bool X509Certificate::Initialize() {
+  serial_number_ = x509_util::ParseSerialNumber(cert_handle_);
 
-  x509_util::ParseDate(&cert_handle_->validity.notBefore, &valid_start_);
-  x509_util::ParseDate(&cert_handle_->validity.notAfter, &valid_expiry_);
-
-  serial_number_ = x509_util::ParseSerialNumber(cert_handle_);
+  return (
+      !serial_number_.empty() &&
+      x509_util::ParsePrincipal(&cert_handle_->subject, &subject_) &&
+      x509_util::ParsePrincipal(&cert_handle_->issuer, &issuer_) &&
+      x509_util::ParseDate(&cert_handle_->validity.notBefore, &valid_start_) &&
+      x509_util::ParseDate(&cert_handle_->validity.notAfter, &valid_expiry_));
 }
 
 std::string X509Certificate::GetDefaultNickname(CertType type) const {
   std::string result;
   if (type == USER_CERT && cert_handle_->slot) {
     // Find the private key for this certificate and see if it has a
     // nickname.  If there is a private key, and it has a nickname, then
     // return that nickname.
     SECKEYPrivateKey* private_key = PK11_FindPrivateKeyFromCert(
         cert_handle_->slot,
@@ skipping 198 matching lines @@
     return false;
   if (SECSuccess != CERT_VerifySignedDataWithPublicKey(
                         &cert_handle->signatureWrap, public_key.get(), NULL)) {
     return false;
   }
   return CERT_CompareName(&cert_handle->subject, &cert_handle->issuer) ==
          SECEqual;
 }
 
 }  // namespace net