Extensions: Move IsIncognitoEnabled to extensions/ from chrome/.

Extensions: Move IsIncognitoEnabled to extensions/ from chrome/.

This CL moves extensions::util::IsIncognitoEnabled from
chrome/browser/extension_util.h(cc) to extensions/browser/extension_util.h(cc).
This is possible since IsIncognitoEnabled does not have any chrome/
dependencies. This is required to prevent a dependency violation for a
subsequent CL where we need to use IsIncognitoEnabled from code in
src/extensions.

BUG=527548
Review-Url: https://codereview.chromium.org/2758103003
Cr-Commit-Position: refs/heads/master@{#462274}
Committed: https://chromium.googlesource.com/chromium/src/+/810e33403ec2cbf4699f5e32cae50b418094deb7

[karandeepb, 2017-03-23 00:07:58]

Patchset #1 (id:1) has been deleted

[karandeepb, 2017-03-23 00:12:48]

Description was changed from

==========
Extensions
==========

to

==========
Extensions: Move IsIncognitoEnabled to extensions/ from chrome/.

This CL moves extensions::util::IsIncognitoEnabled from
chrome/browser/extension_util.h(cc) to extensions/browser/extension_util.h(cc).
This is possible since IsIncognitoEnabled does not have any chrome/
dependencies. This is required to prevent a dependency violation for a
subsequent CL where we need to use IsIncognitoEnabled from code in
src/extensions.

BUG=527548
==========

[karandeepb, 2017-03-24 23:52:56]

karandeepb@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[karandeepb, 2017-03-24 23:52:57]

PTAL Devlin.

[Devlin, 2017-03-27 14:54:57]

lgtm

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
File extensions/browser/extension_util.cc (right):

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
extensions/browser/extension_util.cc:68: if
(!util::CanBeIncognitoEnabled(extension))
nit: this is now the same namespace as CanBeIncognitoEnabled, so no need for
util:: prefix.

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
extensions/browser/extension_util.cc:72: if (extension->location() ==
Manifest::COMPONENT ||
nit: I know this was copy-paste, but since we're here, let's update this to be
if (Manifest::IsComponentLocation(extension->location()))

[karandeepb, 2017-04-05 20:15:56]

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
File extensions/browser/extension_util.cc (right):

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
extensions/browser/extension_util.cc:68: if
(!util::CanBeIncognitoEnabled(extension))
On 2017/03/27 14:54:56, Devlin wrote:
> nit: this is now the same namespace as CanBeIncognitoEnabled, so no need for
> util:: prefix.

Done.

https://codereview.chromium.org/2758103003/diff/20001/extensions/browser/exte...
extensions/browser/extension_util.cc:72: if (extension->location() ==
Manifest::COMPONENT ||
On 2017/03/27 14:54:56, Devlin wrote:
> nit: I know this was copy-paste, but since we're here, let's update this to be
> if (Manifest::IsComponentLocation(extension->location()))

Done.

[karandeepb, 2017-04-05 20:30:21]

karandeepb@chromium.org changed reviewers:
+ sky@chromium.org

[karandeepb, 2017-04-05 20:30:22]

PTAL sky@ for 
-chrome/browser/autocomplete
-chrome/browser/chromeos
-chrome/browser/sync

[sky, 2017-04-05 21:20:28]

LGTM

[karandeepb, 2017-04-05 21:52:26]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2017-04-05 21:52:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2758103003/#ps40001
(title: "Address review")

[commit-bot: I haz the power, 2017-04-05 21:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:41:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491429146064300,
"parent_rev": "64bd88a5b66fc89ba17768422831fd00dd0cf8c6", "commit_rev":
"d4514a3da62e24cb7826fcd37d75ddd6f01beba1"}

[commit-bot: I haz the power, 2017-04-05 23:46:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491429146064300,
"parent_rev": "79e3fb563d663f5d1e2fa68cf71711c2165816b0", "commit_rev":
"810e33403ec2cbf4699f5e32cae50b418094deb7"}

[commit-bot: I haz the power, 2017-04-05 23:47:21]

Description was changed from

==========
Extensions: Move IsIncognitoEnabled to extensions/ from chrome/.

This CL moves extensions::util::IsIncognitoEnabled from
chrome/browser/extension_util.h(cc) to extensions/browser/extension_util.h(cc).
This is possible since IsIncognitoEnabled does not have any chrome/
dependencies. This is required to prevent a dependency violation for a
subsequent CL where we need to use IsIncognitoEnabled from code in
src/extensions.

BUG=527548
==========

to

==========
Extensions: Move IsIncognitoEnabled to extensions/ from chrome/.

This CL moves extensions::util::IsIncognitoEnabled from
chrome/browser/extension_util.h(cc) to extensions/browser/extension_util.h(cc).
This is possible since IsIncognitoEnabled does not have any chrome/
dependencies. This is required to prevent a dependency violation for a
subsequent CL where we need to use IsIncognitoEnabled from code in
src/extensions.

BUG=527548

Review-Url: https://codereview.chromium.org/2758103003
Cr-Commit-Position: refs/heads/master@{#462274}
Committed:
https://chromium.googlesource.com/chromium/src/+/810e33403ec2cbf4699f5e32cae5...
==========

[commit-bot: I haz the power, 2017-04-05 23:47:22]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/810e33403ec2cbf4699f5e32cae5...