third_party/WebKit/Source/modules/notifications/NotificationData.cpp - Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters. (Closed)

Patch Set: fuzzer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp ('k') | third_party/WebKit/Source/web/WebSerializedScriptValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

index 4554db4b4659f39f9849ccdfe28c87406fc960fd..ce95337f6127bc339b3edbbe22c2efc0e834a136 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

@@ -87,8 +87,9 @@ WebNotificationData createWebNotificationData(

v8::Isolate* isolate = data.isolate();

DCHECK(isolate->InContext());

RefPtr<SerializedScriptValue> serializedScriptValue =

- SerializedScriptValue::serialize(isolate, data.v8Value(), nullptr,

- nullptr, exceptionState);

+ SerializedScriptValue::serialize(

+ isolate, data.v8Value(), SerializedScriptValue::SerializeOptions(),

+ exceptionState);

if (exceptionState.hadException())

return WebNotificationData();