third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h - Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h

Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters. (Closed)

Patch Set: fuzzer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h b/third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h

index 25c8ec76963929784f1a0fbe7dd7b99fdcec1c5b..59dc0e20740894c184ab2d4a8ae9a5ed056bbd20 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h

@@ -87,7 +87,9 @@ void V8ServiceWorkerMessageEventInternal::dataAttributeGetterCustom(

v8::Local<v8::Value> data;

if (SerializedScriptValue* serializedValue = event->serializedData()) {

MessagePortArray ports = event->ports();

- data = serializedValue->deserialize(isolate, &ports);

+ SerializedScriptValue::DeserializeOptions options;

+ options.messagePorts = &ports;

+ data = serializedValue->deserialize(isolate, options);

} else if (DOMWrapperWorld::current(isolate).isIsolatedWorld()) {

v8::Local<v8::Value> mainWorldData =

privateCachedData.getFromMainWorld(scriptState, event);