third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 2755383004: Encapsulate optional SerializedScriptValue serialize/deserialize parameters. (Closed)

Patch Set: fuzzer Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueTest.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index c4f7e673b535a583320e17091009ba1bfaace6d6..0e838f1372e0fa00477916e5d7252e04fa577960 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -68,7 +68,9 @@ void V8MessageEvent::dataAttributeGetterCustom(

if (SerializedScriptValue* serializedValue =

event->dataAsSerializedScriptValue()) {

MessagePortArray ports = event->ports();

- result = serializedValue->deserialize(info.GetIsolate(), &ports);

+ SerializedScriptValue::DeserializeOptions options;

+ options.messagePorts = &ports;

+ result = serializedValue->deserialize(info.GetIsolate(), options);

} else {

result = v8::Null(info.GetIsolate());

}