chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc - Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

Issue 2755093002: predictors: Mark before_first_contentful_paint for resources fetched before fcp. (Closed)

Patch Set: before_first_contentful_paint browser_test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor.h » ('j') | chrome/browser/predictors/resource_prefetch_predictor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

index c511043181032e8acbb8386015e9eaaa4f3a03c6..5be09d6d0d955db71bea8bc27794d5519d5913c7 100644

--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

@@ -8,6 +8,7 @@

#include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"

#include "chrome/browser/predictors/resource_prefetch_common.h"

#include "chrome/browser/predictors/resource_prefetch_predictor.h"

+#include "chrome/browser/sessions/session_tab_helper.h"

#include "chrome/test/base/testing_profile.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -46,9 +47,10 @@ class ResourcePrefetchPredictorPageLoadMetricsObserverTest

}

void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {

+ // SessionTabHelper::CreateForWebContents(web_contents());

alexilin 2017/04/21 13:49:05 Do you still need this?

trevordixon 2017/04/25 12:46:09 Nope.

alexilin 2017/04/25 18:42:21 Nit: remove #include "chrome/browser/sessions/ses

tracker->AddObserver(

base::MakeUnique<ResourcePrefetchPredictorPageLoadMetricsObserver>(

- predictor_.get()));

+ predictor_.get(), web_contents()));

}

std::unique_ptr<testing::StrictMock<MockResourcePrefetchPredictor>>