Add the JobComplete callback and error/interrupt information

content/browser/background_fetch/background_fetch_job_controller_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_fetch/background_fetch_job_controller.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind_helpers.h"
@@ skipping 75 matching lines @@
                                                  download_manager_);
   }
 
   void TearDown() override { job_controller_->Shutdown(); }
 
   void InitializeJobController(
       std::unique_ptr<BackgroundFetchJobData> job_data) {
     job_controller_ = base::MakeUnique<BackgroundFetchJobController>(
         kJobGuid, &browser_context_,
         BrowserContext::GetDefaultStoragePartition(&browser_context_),
-        std::move(job_data));
+        std::move(job_data),
+        base::BindOnce(&BackgroundFetchJobControllerTest::DidCompleteJob,
+                       base::Unretained(this)));
   }
 
+  void DidCompleteJob() { did_complete_job_ = true; }
+
   void StartProcessing() {
     base::RunLoop run_loop;
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&BackgroundFetchJobControllerTest::StartProcessingOnIO,
                    base::Unretained(this), run_loop.QuitClosure()));
     run_loop.Run();
   }
 
   void StartProcessingOnIO(const base::Closure& closure) {
     job_controller_->StartProcessing();
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, closure);
   }
 
   BackgroundFetchJobController* job_controller() {
     return job_controller_.get();
   }
   MockDownloadManagerWithCallback* download_manager() {
     return download_manager_;
   }
 
   DownloadItem::Observer* ItemObserver() const { return job_controller_.get(); }
 
+  bool did_complete_job() const { return did_complete_job_; }
+
  private:
+  bool did_complete_job_ = false;
   TestBrowserThreadBundle thread_bundle_;
   TestBrowserContext browser_context_;
   std::unique_ptr<BackgroundFetchJobController> job_controller_;
   MockDownloadManagerWithCallback* download_manager_;
 };
 
 TEST_F(BackgroundFetchJobControllerTest, SingleRequestJob) {
   BackgroundFetchJobInfo job_info(kTag, url::Origin(GURL(kOrigin)),
                                   kServiceWorkerRegistrationId);
   BackgroundFetchRequestInfo request_info(GURL(kTestUrl), kJobGuid);
@@ skipping 14 matching lines @@
   StartProcessing();
 
   // Get one of the pending downloads from the download manager.
   auto& download_items = download_manager()->download_items();
   ASSERT_EQ(1U, download_items.size());
   FakeDownloadItem* item = download_items[0].get();
 
   // Update the observer with no actual change.
   ItemObserver()->OnDownloadUpdated(item);
   EXPECT_FALSE(job_data->IsComplete());
+  EXPECT_FALSE(did_complete_job());
 
   // Update the item to be completed then update the observer. The JobController
   // should update the JobData that the request is complete.
   item->SetState(DownloadItem::DownloadState::COMPLETE);
   ItemObserver()->OnDownloadUpdated(item);
   EXPECT_TRUE(job_data->IsComplete());
+
+  EXPECT_TRUE(did_complete_job());
 }
 
 TEST_F(BackgroundFetchJobControllerTest, MultipleRequestJob) {
   BackgroundFetchJobInfo job_info(kTag, url::Origin(GURL(kOrigin)),
                                   kServiceWorkerRegistrationId);
   std::vector<BackgroundFetchRequestInfo> request_infos;
   for (int i = 0; i < 10; i++) {
     request_infos.emplace_back(GURL(kTestUrl), base::IntToString(i));
   }
 
@@ skipping 23 matching lines @@
 
   for (size_t i = 0; i < 9; i++) {
     // Update the next item to be completed then update the observer.
     ASSERT_EQ(i + 1, download_items.size());
     item = download_items[i].get();
     item->SetState(DownloadItem::DownloadState::COMPLETE);
     ItemObserver()->OnDownloadUpdated(item);
     EXPECT_FALSE(job_data->IsComplete());
   }
   EXPECT_FALSE(job_data->HasRequestsRemaining());
+  EXPECT_FALSE(did_complete_job());
 
   // Finally, update the last request to be complete. The JobController should
   // see that there are no more requests and mark the job as done.
   ASSERT_EQ(10U, download_items.size());
   item = download_items[9].get();
   item->SetState(DownloadItem::DownloadState::COMPLETE);
   ItemObserver()->OnDownloadUpdated(item);
   EXPECT_TRUE(job_data->IsComplete());
+
+  EXPECT_TRUE(did_complete_job());
 }
 
 }  // namespace content