Issue 275303003: Reland: Use real revision mapping in bot_update module

Issue 275303003: Reland: Use real revision mapping in bot_update module (Closed)

Created:
6 years, 7 months ago by iannucci

Modified:
6 years, 7 months ago

Reviewers:
hinoka

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Reland: Use real revision mapping in bot_update module Originally: https://codereview.chromium.org/278943002 R=hinoka@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269695

Patch Set 1 : Original Patch #

Patch Set 3 : Fix nits, copy GOT_REVISION_MAPPING sub-dict to avoid modifying the global one. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+355 lines, -26 lines)			Patch
M	scripts/slave/bot_update.py	View	1 2	5 chunks	+30 lines, -14 lines	0 comments	Download
M	scripts/slave/recipe_modules/android/example.expected/basic.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/bot_update/api.py	View		3 chunks	+7 lines, -12 lines	0 comments	Download
M	scripts/slave/recipe_modules/bot_update/example.expected/basic.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/bot_update/example.expected/tryjob.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/basic.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/does_delete_stale_chromium.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/doesnt_sync_if_android_present.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/trybot.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/uses_android_repo.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/uses_goma_test.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/android_webview_aosp.expected/works_if_revision_not_present.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/dynamic_gtest.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_ChromeOS.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Linux_x64.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__dbg__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS__Clang_dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Trusty__dbg__32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_git_LinuxGit_x64.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_git_MacGit.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_git_WinGit.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_git_WinGitXP.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Clang__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Sync.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__1__32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Tests__dbg__2__32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Sync.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_6_Tests__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac10_7_Tests__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_6_Tests__dbg__4_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_10_7_Tests__dbg__4_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Interactive_Tests__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_32_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_NaCl_Tests__x86_64_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Vista_Tests__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Sync_x64.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__4_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__5_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__6_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_7_Tests_x64__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__1_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__2_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium.expected/full_chromium_win_XP_Tests__3_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_android_chromium_gn_compile_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_android_chromium_gn_compile_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN__dbg_.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_linux_chromium_gn_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/full_linux_chromium_gn_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/unittest_android_dbg_trybot_success.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/unittest_linux_rel_success.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/unittest_revert_fails.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/unittest_second_sync_fails.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_gn.expected/unittest_sync_fails.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/compile_failure.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/compile_failure_linux.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/compile_failure_linux_bot_update.json	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/compile_first_failure_linux.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_clang_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_clang_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_chromeos_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_clang_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_clang_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_compile_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_compile_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty32_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromium_trusty_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_rel_alt.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_compile_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_compile_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_chromium_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_compile_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_compile_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_dbg.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_rel.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_linux.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_win.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_revert_nuke.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure_bot_update.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/gclient_sync_no_data.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/linux_rel_alt.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test_bot_update.json	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/run_presubmit.expected/blink.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/run_presubmit.expected/chromium.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/run_presubmit.expected/gclient_retry.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/run_presubmit.expected/tools_build.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hinoka

lgtm % nits https://codereview.chromium.org/275303003/diff/20001/scripts/slave/bot_update.py File scripts/slave/bot_update.py (right): https://codereview.chromium.org/275303003/diff/20001/scripts/slave/bot_update.py#newcode1064 scripts/slave/bot_update.py:1064: if options.revision_mapping_file is not None: "if ...

6 years, 7 months ago (2014-05-09 23:08:12 UTC) #2

iannucci

all better https://chromiumcodereview.appspot.com/275303003/diff/20001/scripts/slave/bot_update.py File scripts/slave/bot_update.py (right): https://chromiumcodereview.appspot.com/275303003/diff/20001/scripts/slave/bot_update.py#newcode1064 scripts/slave/bot_update.py:1064: if options.revision_mapping_file is not None: On 2014/05/09 ...

6 years, 7 months ago (2014-05-11 03:48:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/275303003/40001

6 years, 7 months ago (2014-05-11 03:58:58 UTC) #5

Message was sent while issue was closed.

Change committed as 269695

Expand Messages | Collapse Messages