Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

Issue 2751333004: [Crash Reporting] Only upload Chrome crash reports over unmetered networks. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
index 1fe38fbd95e525d2b77911e66251e7ed0e074536..9be1b7715df5ec5c8b5fe712a957efade1803d03 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
@@ -6,7 +6,6 @@ package org.chromium.android_webview.crash;
import android.content.Context;
import android.net.ConnectivityManager;
-import android.net.NetworkInfo;
import android.webkit.ValueCallback;
import org.chromium.android_webview.PlatformServiceBridge;
@@ -16,6 +15,7 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.components.minidump_uploader.MinidumpUploaderDelegate;
import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
+import org.chromium.components.minidump_uploader.util.NetworkPermissionUtil;
import java.io.File;
@@ -54,14 +54,10 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
}
@Override
public boolean isNetworkAvailableForCrashUploads() {
- // JobScheduler will call onStopJob causing our upload to be interrupted when our
- // network requirements no longer hold.
- // TODO(isherman): This code should really be shared with Chrome. Chrome currently
- // checks only whether the network is WiFi (or ethernet) vs. cellular. Most likely,
- // Chrome should instead check whether the network is metered, as is done here.
- NetworkInfo networkInfo = mConnectivityManager.getActiveNetworkInfo();
- if (networkInfo == null || !networkInfo.isConnected()) return false;
- return !mConnectivityManager.isActiveNetworkMetered();
+ // Note that this is the same critierion that the JobScheduler uses to schedule the
+ // job. JobScheduler will call onStopJob causing our upload to be interrupted when
+ // our network requirements no longer hold.
+ return NetworkPermissionUtil.isNetworkUnmetered(mConnectivityManager);
}
@Override
public boolean isUsageAndCrashReportingPermittedByUser() {
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698