Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/devtools/device/devtools_android_bridge.h

Issue 274573002: DevTools: Extract ADB specific requests from DevToolsAndroidBridge into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 virtual std::string GetFrontendURL() = 0; 105 virtual std::string GetFrontendURL() = 0;
106 }; 106 };
107 107
108 typedef base::Callback<void(RemotePage*)> RemotePageCallback; 108 typedef base::Callback<void(RemotePage*)> RemotePageCallback;
109 109
110 class RemoteBrowser : public base::RefCounted<RemoteBrowser> { 110 class RemoteBrowser : public base::RefCounted<RemoteBrowser> {
111 public: 111 public:
112 RemoteBrowser( 112 RemoteBrowser(
113 scoped_refptr<DevToolsAndroidBridge> android_bridge, 113 scoped_refptr<DevToolsAndroidBridge> android_bridge,
114 const std::string& serial, 114 const std::string& serial,
115 const std::string& socket); 115 const AndroidDeviceManager::BrowserInfo& browser_info);
116 116
117 std::string serial() { return serial_; } 117 std::string serial() { return serial_; }
118 std::string socket() { return socket_; } 118 std::string socket() { return socket_; }
119 119
120 std::string display_name() { return display_name_; } 120 std::string display_name() { return display_name_; }
121 void set_display_name(const std::string& name) { display_name_ = name; } 121 void set_display_name(const std::string& name) { display_name_ = name; }
122 122
123 std::string version() { return version_; } 123 std::string version() { return version_; }
124 void set_version(const std::string& version) { version_ = version; } 124 void set_version(const std::string& version) { version_ = version; }
125 125
126 bool IsChrome() const; 126 bool IsChrome() const;
127 bool IsWebView() const;
127 128
128 typedef std::vector<int> ParsedVersion; 129 typedef std::vector<int> ParsedVersion;
129 ParsedVersion GetParsedVersion() const; 130 ParsedVersion GetParsedVersion() const;
130 131
131 std::vector<RemotePage*> CreatePages(); 132 std::vector<RemotePage*> CreatePages();
132 void SetPageDescriptors(const base::ListValue&); 133 void SetPageDescriptors(const base::ListValue&);
133 134
134 typedef base::Callback<void(int, const std::string&)> JsonRequestCallback; 135 typedef base::Callback<void(int, const std::string&)> JsonRequestCallback;
135 void SendJsonRequest(const std::string& request, 136 void SendJsonRequest(const std::string& request,
136 const JsonRequestCallback& callback); 137 const JsonRequestCallback& callback);
(...skipping 27 matching lines...) Expand all
164 165
165 void RespondToOpenOnUIThread( 166 void RespondToOpenOnUIThread(
166 const DevToolsAndroidBridge::RemotePageCallback& callback, 167 const DevToolsAndroidBridge::RemotePageCallback& callback,
167 int result, 168 int result,
168 const std::string& response); 169 const std::string& response);
169 170
170 scoped_refptr<DevToolsAndroidBridge> android_bridge_; 171 scoped_refptr<DevToolsAndroidBridge> android_bridge_;
171 const std::string serial_; 172 const std::string serial_;
172 const std::string socket_; 173 const std::string socket_;
173 std::string display_name_; 174 std::string display_name_;
175 const AndroidDeviceManager::BrowserInfo::Type type_;
174 std::string version_; 176 std::string version_;
175 scoped_ptr<base::ListValue> page_descriptors_; 177 scoped_ptr<base::ListValue> page_descriptors_;
176 178
177 DISALLOW_COPY_AND_ASSIGN(RemoteBrowser); 179 DISALLOW_COPY_AND_ASSIGN(RemoteBrowser);
178 }; 180 };
179 181
180 typedef std::vector<scoped_refptr<RemoteBrowser> > RemoteBrowsers; 182 typedef std::vector<scoped_refptr<RemoteBrowser> > RemoteBrowsers;
181 183
182 class RemoteDevice : public base::RefCounted<RemoteDevice> { 184 class RemoteDevice : public base::RefCounted<RemoteDevice> {
183 public: 185 public:
184 RemoteDevice(scoped_refptr<DevToolsAndroidBridge> android_bridge, 186 RemoteDevice(scoped_refptr<DevToolsAndroidBridge> android_bridge,
185 const std::string& serial, 187 const std::string& serial,
186 const std::string& model, 188 const AndroidDeviceManager::DeviceInfo& device_info,
187 bool connected); 189 bool connected);
188 190
189 std::string serial() { return serial_; } 191 std::string serial() { return serial_; }
190 std::string model() { return model_; } 192 std::string model() { return model_; }
191 bool is_connected() { return connected_; } 193 bool is_connected() { return connected_; }
192 void AddBrowser(scoped_refptr<RemoteBrowser> browser);
193
194 RemoteBrowsers& browsers() { return browsers_; } 194 RemoteBrowsers& browsers() { return browsers_; }
195 gfx::Size screen_size() { return screen_size_; } 195 gfx::Size screen_size() { return screen_size_; }
196 void set_screen_size(const gfx::Size& size) { screen_size_ = size; }
197 196
198 void OpenSocket(const std::string& socket_name, 197 void OpenSocket(const std::string& socket_name,
199 const AndroidDeviceManager::SocketCallback& callback); 198 const AndroidDeviceManager::SocketCallback& callback);
200 199
201 private: 200 private:
202 friend class base::RefCounted<RemoteDevice>; 201 friend class base::RefCounted<RemoteDevice>;
203 virtual ~RemoteDevice(); 202 virtual ~RemoteDevice();
204 203
205 scoped_refptr<DevToolsAndroidBridge> android_bridge_; 204 scoped_refptr<DevToolsAndroidBridge> android_bridge_;
206 std::string serial_; 205 std::string serial_;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 289
291 typedef std::vector<DeviceCountListener*> DeviceCountListeners; 290 typedef std::vector<DeviceCountListener*> DeviceCountListeners;
292 DeviceCountListeners device_count_listeners_; 291 DeviceCountListeners device_count_listeners_;
293 292
294 AndroidDeviceManager::DeviceProviders device_providers_; 293 AndroidDeviceManager::DeviceProviders device_providers_;
295 PrefChangeRegistrar pref_change_registrar_; 294 PrefChangeRegistrar pref_change_registrar_;
296 DISALLOW_COPY_AND_ASSIGN(DevToolsAndroidBridge); 295 DISALLOW_COPY_AND_ASSIGN(DevToolsAndroidBridge);
297 }; 296 };
298 297
299 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_ 298 #endif // CHROME_BROWSER_DEVTOOLS_DEVICE_DEVTOOLS_ANDROID_BRIDGE_H_
OLDNEW
« no previous file with comments | « chrome/browser/devtools/device/android_device_manager.cc ('k') | chrome/browser/devtools/device/devtools_android_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698